Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated pigeon and set minimum SDK version to Flutter 3.16/Dart 3.2 #351

Merged
merged 7 commits into from
Feb 6, 2025
Merged

Updated pigeon and set minimum SDK version to Flutter 3.16/Dart 3.2 #351

merged 7 commits into from
Feb 6, 2025

Conversation

Robert-SD
Copy link
Collaborator

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2025

LCOV of commit a55dc9d during Check PR #1038

Summary coverage rate:
  lines......: 9.9% (136 of 1376 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate:
                                                                                                |Lines       |Functions  |Branches    
  Filename                                                                                      |Rate     Num|Rate    Num|Rate     Num
  ====================================================================================================================================
  lib/src/components/component_flutter_api.dart                                                 | 0.0%     16|    -     0|    -      0
  lib/src/drop_in/drop_in.dart                                                                  | 0.0%    161|    -     0|    -      0

descorp
descorp previously approved these changes Feb 5, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2025

LCOV of commit 43bb806 during Check PR #1039

Summary coverage rate:
  lines......: 9.9% (136 of 1376 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate:
                                                                                                |Lines       |Functions  |Branches    
  Filename                                                                                      |Rate     Num|Rate    Num|Rate     Num
  ====================================================================================================================================
  lib/src/components/component_flutter_api.dart                                                 | 0.0%     16|    -     0|    -      0
  lib/src/drop_in/drop_in.dart                                                                  | 0.0%    161|    -     0|    -      0

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2025

LCOV of commit 1fb55d8 during Check PR #1040

Summary coverage rate:
  lines......: 9.9% (136 of 1376 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate:
                                                                                                |Lines       |Functions  |Branches    
  Filename                                                                                      |Rate     Num|Rate    Num|Rate     Num
  ====================================================================================================================================
  lib/src/components/component_flutter_api.dart                                                 | 0.0%     16|    -     0|    -      0
  lib/src/drop_in/drop_in.dart                                                                  | 0.0%    161|    -     0|    -      0

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2025

LCOV of commit fe37dc2 during Check PR #1041

Summary coverage rate:
  lines......: 9.9% (136 of 1376 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate:
                                                                                                |Lines       |Functions  |Branches    
  Filename                                                                                      |Rate     Num|Rate    Num|Rate     Num
  ====================================================================================================================================
  lib/src/components/component_flutter_api.dart                                                 | 0.0%     16|    -     0|    -      0
  lib/src/drop_in/drop_in.dart                                                                  | 0.0%    161|    -     0|    -      0

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2025

LCOV of commit ef6b1e3 during Check PR #1042

Summary coverage rate:
  lines......: 9.9% (136 of 1376 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate:
                                                                                                |Lines       |Functions  |Branches    
  Filename                                                                                      |Rate     Num|Rate    Num|Rate     Num
  ====================================================================================================================================
  lib/src/components/component_flutter_api.dart                                                 | 0.0%     16|    -     0|    -      0
  lib/src/drop_in/drop_in.dart                                                                  | 0.0%    161|    -     0|    -      0

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2025

LCOV of commit b704b72 during Check PR #1043

Summary coverage rate:
  lines......: 9.9% (136 of 1376 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate:
                                                                                                |Lines       |Functions  |Branches    
  Filename                                                                                      |Rate     Num|Rate    Num|Rate     Num
  ====================================================================================================================================
  lib/src/components/component_flutter_api.dart                                                 | 0.0%     16|    -     0|    -      0
  lib/src/drop_in/drop_in.dart                                                                  | 0.0%    161|    -     0|    -      0

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2025

LCOV of commit 3df614e during Check PR #1044

Summary coverage rate:
  lines......: 9.9% (136 of 1376 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate:
                                                                                                |Lines       |Functions  |Branches    
  Filename                                                                                      |Rate     Num|Rate    Num|Rate     Num
  ====================================================================================================================================
  lib/src/components/component_flutter_api.dart                                                 | 0.0%     16|    -     0|    -      0
  lib/src/drop_in/drop_in.dart                                                                  | 0.0%    161|    -     0|    -      0

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 5, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
2.3% Coverage on New Code (required ≥ 80%)
3.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@Robert-SD Robert-SD marked this pull request as ready for review February 5, 2025 15:34
@Robert-SD Robert-SD merged commit 871e908 into main Feb 6, 2025
17 of 18 checks passed
@Robert-SD Robert-SD deleted the feature/updateDependencies branch February 6, 2025 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@descorp descorp descorp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Robert-SD @descorp