Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged platform communication for Drop-in into one single stream. #353

Merged
merged 7 commits into from
Feb 11, 2025

Conversation

Robert-SD
Copy link
Collaborator

No description provided.

Copy link

github-actions bot commented Feb 7, 2025

LCOV of commit 4f068cf during Check PR #1047

Summary coverage rate:
  lines......: 9.9% (136 of 1374 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate:
                                                                                                |Lines       |Functions  |Branches    
  Filename                                                                                      |Rate     Num|Rate    Num|Rate     Num
  ====================================================================================================================================
  lib/src/drop_in/drop_in.dart                                                                  | 0.0%    161|    -     0|    -      0
  lib/src/drop_in/drop_in_flutter_api.dart                                                      | 0.0%      2|    -     0|    -      0

Copy link

github-actions bot commented Feb 7, 2025

LCOV of commit ef5b2f4 during Check PR #1048

Summary coverage rate:
  lines......: 9.9% (136 of 1374 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate:
                                                                                                |Lines       |Functions  |Branches    
  Filename                                                                                      |Rate     Num|Rate    Num|Rate     Num
  ====================================================================================================================================
  lib/src/drop_in/drop_in.dart                                                                  | 0.0%    161|    -     0|    -      0
  lib/src/drop_in/drop_in_flutter_api.dart                                                      | 0.0%      2|    -     0|    -      0

Copy link

github-actions bot commented Feb 7, 2025

LCOV of commit aca7427 during Check PR #1049

Summary coverage rate:
  lines......: 9.9% (136 of 1374 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate:
                                                                                                |Lines       |Functions  |Branches    
  Filename                                                                                      |Rate     Num|Rate    Num|Rate     Num
  ====================================================================================================================================
  lib/src/drop_in/drop_in.dart                                                                  | 0.0%    161|    -     0|    -      0
  lib/src/drop_in/drop_in_flutter_api.dart                                                      | 0.0%      2|    -     0|    -      0

@Robert-SD Robert-SD marked this pull request as ready for review February 7, 2025 13:00
Copy link

github-actions bot commented Feb 7, 2025

LCOV of commit d321a52 during Check PR #1050

Summary coverage rate:
  lines......: 9.9% (136 of 1368 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate:
                                                                                                |Lines       |Functions  |Branches    
  Filename                                                                                      |Rate     Num|Rate    Num|Rate     Num
  ====================================================================================================================================
  lib/src/adyen_checkout.dart                                                                   | 4.4%     45|    -     0|    -      0
  lib/src/common/checkout_flutter.dart                                                          | 0.0%      2|    -     0|    -      0
  lib/src/drop_in/drop_in.dart                                                                  | 0.0%    155|    -     0|    -      0

Copy link

LCOV of commit 7441e5e during Check PR #1051

Summary coverage rate:
  lines......: 9.9% (136 of 1368 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate:
                                                                                                |Lines       |Functions  |Branches    
  Filename                                                                                      |Rate     Num|Rate    Num|Rate     Num
  ====================================================================================================================================
  lib/src/adyen_checkout.dart                                                                   | 4.4%     45|    -     0|    -      0
  lib/src/drop_in/drop_in.dart                                                                  | 0.0%    155|    -     0|    -      0
  lib/src/drop_in/drop_in_flutter.dart                                                          | 0.0%      2|    -     0|    -      0

Copy link

LCOV of commit faf87e1 during Check PR #1053

Summary coverage rate:
  lines......: 9.9% (136 of 1371 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate:
                                                                                                |Lines       |Functions  |Branches    
  Filename                                                                                      |Rate     Num|Rate    Num|Rate     Num
  ====================================================================================================================================
  lib/src/adyen_checkout.dart                                                                   | 4.4%     45|    -     0|    -      0
  lib/src/drop_in/drop_in.dart                                                                  | 0.0%    158|    -     0|    -      0
  lib/src/drop_in/drop_in_flutter.dart                                                          | 0.0%      2|    -     0|    -      0

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
8.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@Robert-SD Robert-SD merged commit 2eeac97 into main Feb 11, 2025
17 of 18 checks passed
@Robert-SD Robert-SD deleted the refactor/DropInPlatformCommunication branch February 11, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants