[ECP-8748] Fix line item calculations for open invoice payment methods #2419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
khushboo-singhvi
previously approved these changes
Mar 19, 2024
RokPopov
previously approved these changes
Mar 19, 2024
candemiralp
dismissed stale reviews from RokPopov and khushboo-singhvi
via
437db15
khushboo-singhvi
approved these changes
Mar 21, 2024
peterojo
approved these changes
Mar 21, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While calculating the tax included and excluded values for open invoice line items, plugin had an issue for the cases of discount applied carts. While solving this issue,
discount_tax_compensation_amountfield has been used andChargedCurrencyclass has been refactored.Tested scenarios