Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ECP-8825] Enable pipeline runs for external contributions #2451

Merged
merged 19 commits into from
Jan 19, 2024
Merged

Conversation

cenkiravul
Copy link
Contributor

@cenkiravul cenkiravul commented Jan 17, 2024

Description

This change adds the possibility of running pipelines for PRs that are created by external contributors.

Tested scenarios

  • Make sure the PRs by internal users still work as they should
  • Make sure that the PRs from external contributors work properly, and they require a codeowner approval to start

Fixes
ECP-8825

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@cenkiravul cenkiravul merged commit da50719 into develop Jan 19, 2024
7 checks passed
@cenkiravul cenkiravul deleted the ECP-8825 branch January 19, 2024 14:21
hossam-adyen pushed a commit that referenced this pull request Jan 22, 2024
* Add e2e flow for external contributors

* Add dispatch for debugging

* Tweak workflow name

* Tweak workflow

* Debug

* Remove draft pipeline

* Update e2e test pipeline

* Update GraphQL test pipeline

* Update Main CI workflow

* Update RestAPI test workflow

* DEBUG - Add test pipeline

* Add authorization step

* DEBUG - Test auth step

* Define an internal environment

* DEBUG - Try removing auth step and switch to conditional

* Remove trial pipeline

* Add designated worklfow for debugging

* Embed authorize step in build and add conditional

* Remove debug pipeline
@khushboo-singhvi khushboo-singhvi mentioned this pull request Jan 23, 2024
RokPopov added a commit that referenced this pull request Jul 24, 2024
* [ECP-8715] Update to model based PHP Library

* Update adyen/php-api-library to ^17.0.0

* fix: Notification model `getUpdatedAt` method uses `created_at` date instead of `updated_at` (#2417)

Co-authored-by: Peter Ojo <peterojo@users.noreply.github.com>

* Fix 301 Return value while running command console (#2396)

* [FIX] Fix 301 Return value while running command console

* Add Magento\Framework\Console\Cli constants since deprecated Symfony\Component\Console\Command\Command

---------

Co-authored-by: Rok Popov Ledinski <rok.popov.ledinski90@gmail.com>
Co-authored-by: Can Demiralp <ecandemiralp@gmail.com>
Co-authored-by: hossam-adyen <132500300+hossam-adyen@users.noreply.github.com>

* Update dependency squizlabs/php_codesniffer to ~3.8.0 (#2426)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: hossam-adyen <132500300+hossam-adyen@users.noreply.github.com>

* [ECP-8893] Allow usage of storedPaymentMethodId on headless payment requests (#2431)

* [ECP-8893] Allow usage of storedPaymentMethodId in the request

* [ECP-8893] Write unit tests

* [ECP-8825] Enable pipeline runs for external contributions (#2451)

* Add e2e flow for external contributors

* Add dispatch for debugging

* Tweak workflow name

* Tweak workflow

* Debug

* Remove draft pipeline

* Update e2e test pipeline

* Update GraphQL test pipeline

* Update Main CI workflow

* Update RestAPI test workflow

* DEBUG - Add test pipeline

* Add authorization step

* DEBUG - Test auth step

* Define an internal environment

* DEBUG - Try removing auth step and switch to conditional

* Remove trial pipeline

* Add designated worklfow for debugging

* Embed authorize step in build and add conditional

* Remove debug pipeline

* [ECP-8890] Update class references (#2441)

* [ECP-8878] Add pspReference to additional_information (#2443)

* [ECP-8787] Handle Pending resultCode on multishipping (#2448)

* [ECP-8822] Update management webhook endpoint (#2440)

* Support model based for gitcards payments and refactor

* Support model based for TransactionCancel and refactor

* Support model based for TransactionRefund and refactor

* Support model based for TransactionCapture

* Support model based for TransactionDonate

* Support model based for TransactionPaymentLinks

* Support model based for PaymentRequest

* Update Return controller

* Update OrdersApi

* Update PaymentsDetails helper

* Remove createAdyenCheckoutService and deprecated checkout service

* Use UtilityApi

* Use model based for diffrent places

* Use Adyen\Service\Management APIs

* Fix unit tests

* Fix unit tests

* Fix conflict getMerchantAccountsAndClientKey

* Fix all unit tests

* entirely parse models to array

* Fix TypeError: Adyen\Service\Checkout\OrdersApi::getBalanceOfGiftCard(): Argument #1 ($balanceCheckRequest) must be of type Adyen\Model\Checkout\BalanceCheckRequest, array given

* use query params to pass page size and pagenumber

* Fix new unit tests

* Add AdyenPaymentMethodsBalanceTest

* update DataTest new tests

* Sonarcloud check fixes

* Add MerchantAccountsTest

* Add more tests for ManagementHelperTest

* update TransactionPaymentTest

* Add TransactionCaptureTest

* Add TransactionCancelTest

* Update DataTest

* Add WebhookTestTest && AutoConfigurationTest

* Add more code coverage

* Add more code coverage in DataTest.php

* mark createAdyenRecurringService & createAdyenCheckoutService as deprecated

* Update ManagementHelper.php

* Small refactor

* unit test fixes

* CS

* Update PaymentDetailsTest.php

* [ECP-8715] Fix PaymentsDetails class after merge conflict

* [ECP-8715] Fix unit tests after merge conflict

* [ECP-8715] Fix unit tests after merge conflict

* [ECP-8715] Fix redundant line

* FixPaymentDetails

* [ECP-8715] Add type declarations

* [ECP-8715] Fix test webhook url builder

* [ECP-8715] Add type declarations

* [ECP-8715] Formatting

* [ECP-8715] Format the response array

* [ECP-8715] Format the response array and add type declarations

* [ECP-8715] Fix amount issue on second partial payment and declare types

* [ECP-8715] Add type declarations and use toArray() method

* [ECP-8715] Add type declarations and use toArray() method

* [ECP-8715] Formatting

* [ECP-8715] Use toArray() method

* [ECP-8715] Use toArray() method and add type declarations

* [ECP-8715] Use toArray() method and add type declarations remove unused exception

* [ECP-8715] Use toArray() method and add type declarations

* [ECP-8715] Use toArray() method and add type declarations

* [ECP-8715] Fx return value, use toArray() method and add type declarations

* [ECP-8715] Use toArray() method and add type declarations

* [ECP-8715] Use toArray() method and add type declarations

* [ECP-8715] Add type declarations

* [ECP-8715] Use toArray() method and add type declarations

* [ECP-8715] Fix Capture unit tests

* [ECP-8715] Fix mixed unit tests

* [ECP-8715] Fix Data helper unit tests

---------

Co-authored-by: Paweł Ledwig <48790035+pawel-ledwig@users.noreply.github.com>
Co-authored-by: Peter Ojo <peterojo@users.noreply.github.com>
Co-authored-by: Tuyen Nguyen <thinghost76@gmail.com>
Co-authored-by: Rok Popov Ledinski <rok.popov.ledinski90@gmail.com>
Co-authored-by: Can Demiralp <ecandemiralp@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Cenk Kucukiravul <cenkiravul35@gmail.com>
Co-authored-by: Can Demiralp <can.demiralp@adyen.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants