Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix - Skip excluded payment methods from activation toggling #2503

Merged
merged 17 commits into from
Mar 7, 2024
Merged

Fix - Skip excluded payment methods from activation toggling #2503

merged 17 commits into from
Mar 7, 2024

Conversation

hossam-adyen
Copy link
Contributor

@hossam-adyen hossam-adyen commented Feb 12, 2024 •
edited by candemiralp
Loading

Description

After introducing the recurring setup with this PR, if a customer set his POS disabled then ran setup:upgrade, the disabled POS payment method will be enabled and this is fixing that by filtering out POS payment

Screenshot 2024-02-12 at 3 52 05 PM

Tested scenarios

Fixes #2533

@hossam-adyen hossam-adyen added the Fix Indicates a bug fix label Feb 12, 2024
@hossam-adyen hossam-adyen requested a review from a team as a code owner February 12, 2024 14:55
@hossam-adyen hossam-adyen changed the title Fix - Skip POS payment method from toggling as this config is visual via Admin panel Fix - Skip excluded payment methods from PMs activation toggling Feb 12, 2024
@hossam-adyen hossam-adyen changed the title Fix - Skip excluded payment methods from PMs activation toggling Fix - Skip excluded payment methods from activation toggling Feb 12, 2024
@candemiralp candemiralp self-requested a review February 21, 2024 14:09
candemiralp
candemiralp previously approved these changes Feb 21, 2024
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@candemiralp candemiralp merged commit 8785839 into develop Mar 7, 2024
10 of 11 checks passed
@candemiralp candemiralp deleted the skip-pos-from-toggle-activation branch March 7, 2024 08:01
@candemiralp candemiralp mentioned this pull request Mar 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khushboo-singhvi khushboo-singhvi khushboo-singhvi approved these changes

@candemiralp candemiralp candemiralp approved these changes

Assignees
No one assigned
Labels
Fix Indicates a bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adyen POS Coud API is always activated after a new installation
3 participants
@hossam-adyen @khushboo-singhvi @candemiralp