Skip to content

Commit f434495

Browse files
setting instant payment method as active pm when clicked
1 parent 8a5fa72 commit f434495

File tree

4 files changed

+20
-12
lines changed

4 files changed

+20
-12
lines changed

.changeset/afraid-roses-cheer.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@adyen/adyen-web': patch
3+
---
4+
5+
GooglePay - Fixed challengeWindowSize property when using Google Pay as Instant payment type inside Drop-in

packages/lib/src/components/Dropin/components/PaymentMethod/InstantPaymentMethods.tsx

+11-9
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,22 @@
1-
import { Fragment, h } from 'preact';
1+
import { h } from 'preact';
22
import UIElement from '../../../internal/UIElement/UIElement';
33
import './InstantPaymentMethods.scss';
44

55
interface InstantPaymentMethodsProps {
66
paymentMethods: UIElement[];
7+
onSelect: (paymentMethod: UIElement) => void;
78
}
89

9-
function InstantPaymentMethods({ paymentMethods }: InstantPaymentMethodsProps) {
10+
function InstantPaymentMethods({ paymentMethods, onSelect }: InstantPaymentMethodsProps) {
1011
return (
11-
<Fragment>
12-
<ul className="adyen-checkout__instant-payment-methods-list">
13-
{paymentMethods.map(pm => (
14-
<li key={pm.type}>{pm.render()}</li>
15-
))}
16-
</ul>
17-
</Fragment>
12+
<ul className="adyen-checkout__instant-payment-methods-list">
13+
{paymentMethods.map(pm => (
14+
// eslint-disable-next-line jsx-a11y/click-events-have-key-events, jsx-a11y/no-noninteractive-element-interactions
15+
<li key={pm._id} data-testid={pm.type} onClick={() => onSelect(pm)}>
16+
{pm.render()}
17+
</li>
18+
))}
19+
</ul>
1820
);
1921
}
2022

packages/lib/src/components/Dropin/components/PaymentMethod/PaymentMethodList.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ const PaymentMethodList = ({
8080
/>
8181
)}
8282

83-
{hasInstantPaymentMethods && <InstantPaymentMethods paymentMethods={instantPaymentMethods} />}
83+
{hasInstantPaymentMethods && <InstantPaymentMethods paymentMethods={instantPaymentMethods} onSelect={onSelect} />}
8484

8585
{hasStoredPaymentMethods && (
8686
<PaymentMethodsContainer

packages/lib/storybook/stories/dropin/Dropin.stories.tsx

+3-2
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,12 @@ const meta: MetaConfiguration<DropinConfiguration> = {
2626
args: {
2727
componentConfiguration: getComponentConfigFromUrl() ?? {
2828
showRadioButton: false,
29-
instantPaymentTypes: ['googlepay'],
29+
instantPaymentTypes: ['googlepay', 'applepay'],
3030
showRemovePaymentMethodButton: false,
3131
paymentMethodsConfiguration: {
3232
googlepay: {
33-
buttonType: 'plain'
33+
buttonType: 'plain',
34+
challengeWindowSize: '05'
3435
}
3536
}
3637
}

0 commit comments

Comments
 (0)