chore: set msw for storybook #3132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Size Change: 0 B Total Size: 789 kB ℹ️ View Unchanged
|
size-limit report 📦
|
longyulongyu
force-pushed
the
setup-storybook-msw
branch
2 times, most recently
from
862745e to
3d46f5c
Compare
longyulongyu
requested review from
pabloai,
sponglord,
m1aw and
ribeiroguilherme
as code owners
ribeiroguilherme
approved these changes
Feb 21, 2025
longyulongyu
force-pushed
the
setup-storybook-msw
branch
from
3d46f5c to
084797a
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This MR is about initializing
mswonly for thedevelopmentmode for now, until there is a use case to enable it for the production mode.packages/lib/.storybook/preview.tsxdoes not get the correctprocess.env.NODE_ENVvalue because we are not passing the correct mode togenerateEnvironmentVariables, now it's fixed.Context: Vite automatically sets the
process.env.NODE_ENVtodevelopmentorproductionrespectively when running the Storybook or building the Storybook. We just need to pass theprocess.env.NODE_ENVwhen callinggenerateEnvironmentVariablesfunction.Another issue I noticed - running
storybook builddoesn't load the environment variables properly, I think it can be solved by changing the second parameter ofloadEnvto pass the folder of the.envfile. But I don't know why it works fordevelopmentmode.Tested scenarios
Build for the lib and storybook are working correctly.