Storybook upgrade #3145
Merged
Storybook upgrade #3145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ribeiroguilherme
requested review from
pabloai,
sponglord,
m1aw and
longyulongyu
as code owners
|
|
Size Change: 0 B Total Size: 790 kB ℹ️ View Unchanged
|
size-limit report 📦
|
longyulongyu
approved these changes
Feb 20, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Storybook 8.4.0 replaced Express server by Polka . That broke our Storybook integration, since we were using their Express server for our dev environment.
To fix that, we stopped using their server as part of
middleware.jsand instead we are proxying the requests using Vite server to our Express server.To be able to proxy only the API requests that are necessary, a prefix was added to our current endpoints (
/api/) . So Vite server can proxy all the requests targeting this path to our Express server.What changes for us now:
What was tested:
yarn test:e2e