GooglePay - Handling challengeWindowSize when using GooglePay as Drop-in Instant payment method #3170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ribeiroguilherme
requested review from
sponglord,
m1aw and
longyulongyu
as code owners
🦋 Changeset detectedLatest commit: f434495 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
Size Change: +53 B (+0.01%) Total Size: 790 kB
ℹ️ View Unchanged
|
size-limit report 📦
|
longyulongyu
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Instant payment methods were never set as 'active payment method' within Drop-in.
When handling actions inside Drop-in (E.g. 3DS2 for GooglePay), its code relies on the 'activePaymentMethod' , and in this case the active payment method was being another payment method instead of the one being clicked.
In this PR, an event listener is added to the markup wrapping the payment method (same approach as we have here). Once the payment method is clicked, it is set as the active payment method.
There is a UI effect though: If there is one payment method active and open (e.g. card) , and shopper clicks in an instant payment method button, the current active payment method will be collapsed since it is not the active payment method anymore.
Tested scenario
Drop-in on Storybook, having the googlepay configured as instant payment type and setting its challengeWindowSize to a different value than the default.