Fastlane analytics #3175
Open
Fastlane analytics #3175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Size Change: +1.06 kB (+0.13%) Total Size: 810 kB
ℹ️ View Unchanged
|
|
size-limit report 📦
|
ribeiroguilherme
requested review from
pabloai,
sponglord,
m1aw and
longyulongyu
as code owners
| /** | ||
| * Fastlane | ||
| */ | ||
| // CHECK: Do we always append the prop even if it is not used? e.g. merchants not using fastlane |
There was a problem hiding this comment.
Not sure what is the best here
There was a problem hiding this comment.
For other, universal, props we want to know what config the merchant has ended up with, be it something they've set deliberately or a default that we've set for them.
But for something opt-in like Fastlane, we should only send it if it's relevant to their setup, imo
sponglord
reviewed
Mar 13, 2025
| infoType: InfoEventTypes.clicked, | ||
| target: 'fastlane_signup_consent_toggle', | ||
| configData: { | ||
| isToggleOn: newValue |
There was a problem hiding this comment.
Are there any backend changes needed?
Have you tested that we don't get network errors sending in new properties like "isToggleOn", "isFastlaneSignupRendered"?
sponglord
reviewed
Mar 13, 2025
| this.props.modules?.analytics.sendAnalytics('dropin', { | ||
| type: ANALYTICS_EVENT.info, | ||
| infoType: InfoEventTypes.clicked, | ||
| target: 'otherpaymentmethod_button' |
There was a problem hiding this comment.
Similar to my comment above - can the backend handle this target value, "otherpaymentmethod_button" without errors?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary