Typescript - Fixing triple slash directives on build file #3178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ribeiroguilherme
requested review from
sponglord,
m1aw and
longyulongyu
as code owners
🦋 Changeset detectedLatest commit: ec98a79 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for adyen-web ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Not sure why this file is in the diff, since it is the same content as the one in the remote
|
|
Size Change: 0 B Total Size: 792 kB ℹ️ View Unchanged
|
size-limit report 📦
|
m1aw
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The generated types definition didn't contain the references to the googlepay and applepay js types.
For some reason our tsconfig + typescript compiler is not adding the triple slash directives.
To fix that, I added a script as part of the build types pipeline which add the directives manually.
Fixes #3162