Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse talker ID GQ as QZSS #144

Merged
merged 2 commits into from
Feb 16, 2025
Merged

Parse talker ID GQ as QZSS #144

merged 2 commits into from
Feb 16, 2025

Conversation

Tosainu
Copy link
Contributor

@Tosainu Tosainu commented Feb 15, 2025

I noticed that parse("$GQGSV,...") returns UnknownGnssType("GQ") instead of GSV(GsvData { gnss_type: Qzss, ... }). I fixed this so that it can parse GQ as GnssType::Qzss.

Copy link

codecov bot commented Feb 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.67%. Comparing base (68a44c0) to head (3f9fb77).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #144   +/-   ##
=======================================
  Coverage   78.67%   78.67%           
=======================================
  Files          39       39           
  Lines        1449     1449           
=======================================
  Hits         1140     1140           
  Misses        309      309           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@elpiel elpiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@elpiel elpiel merged commit 0f69998 into AeroRust:main Feb 16, 2025
15 checks passed
@Tosainu Tosainu deleted the gq-as-qzss branch February 16, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants