Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Review #9

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Project Review #9

wants to merge 1 commit into from

Conversation

nj7
Copy link

@nj7 nj7 commented Nov 13, 2022

Afzhal-ahmed-s

  • Added Bean object equal method, which is nice to see
  • Dao object could be well written.
  • Encalsulation of code could be done.
  • Nice to see project dependency have been added in the project along with sql dump
  • Use custom hashcode is really nice.
  • Design of application is good.
  • Using static variable while connecting to data base, with static user name and password is not accecptable.
  • Readme file is empty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant