Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(synthetic-chain): Improve env_setup.sh function output #195

Merged
merged 7 commits into from
Nov 14, 2024

Conversation

gibson042
Copy link
Member

@gibson042 gibson042 commented Nov 13, 2024

Make CI logs more readable by:

  • prefixing lines with "waitForBlock"/"voteLatestProposalAndWait"/etc.
  • always including details (iteration count, observed block height, proposal id, etc.)
  • omitting output that doesn't convey new information "done", "reading", etc.)

@agoric/synthetic-chain library

  • passes CI
  • bump patch version
  • publish

@gibson042 gibson042 requested a review from turadg November 13, 2024 23:50
Copy link
Member

@turadg turadg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope we lose the bash scripts someday but meanwhile a markèd improvement. 🙏

@gibson042 gibson042 enabled auto-merge November 14, 2024 14:54
@gibson042 gibson042 merged commit be44746 into main Nov 14, 2024
2 checks passed
@gibson042 gibson042 deleted the gibson-2024-11-waitforblock-output branch November 14, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants