Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add proposal 87 Fast USDC Beta #220

Merged
merged 6 commits into from
Feb 19, 2025
Merged

add proposal 87 Fast USDC Beta #220

merged 6 commits into from
Feb 19, 2025

Conversation

dckc
Copy link
Member

@dckc dckc commented Feb 18, 2025

refs

@turadg, I'm struggling to grok the PR template.

adopt a passed proposal

When a proposal passes on agoric-3 Mainnet, it should be included in the history that this synthetic image tracks.

  • before this PR, change any fromTag using latest (such as a3p-integration) to use a fixed version (otherwise they will fail when this PR changes latest and they pick it up)
  • before merging this PR, include a link to a PR that adopts its fromTag use-${proposalName} (where proposalName is the part of the agoric-3-proposals proposal directory name after the colon, cf. a3p-integration/proposals)
  • after this PR merges, merge that other PR

@dckc dckc requested review from turadg and mujahidkay February 18, 2025 19:59
@dckc dckc changed the title add propoasl 87 Fast USDC Beta add proposal 87 Fast USDC Beta Feb 18, 2025
@dckc dckc marked this pull request as ready for review February 19, 2025 19:51
Copy link
Member

@turadg turadg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few things to change be need this image in order to test upgrading the beta so I'm going to land this and we can fix it later.

proposer.json:
agd --node $(ARCHIVE_NODE) query gov proposer $(PROPOSAL) -o json >$@

# Get proposer's tranasction history.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

transaction

@@ -0,0 +1,6 @@
# CoreEvalProposal to upgrade vaults and auctions
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revise


echo "[$PROPOSAL] Running proposal declared in package.json"
# copy to run in the proposal package so the dependencies can be resolved
cp /usr/src/upgrade-test-scripts/eval_submission.js .
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file shouldn't be necessary. it's doing the same as happens if it's absent.

# newer proposals declare a submission
echo "[$PROPOSAL] Running proposal declared in package.json"
# copy to run in the proposal package so the dependencies can be resolved
cp /usr/src/upgrade-test-scripts/eval_submission.js .
./eval_submission.js
fi

@turadg turadg merged commit 68b6d01 into main Feb 19, 2025
2 checks passed
@turadg turadg deleted the dc-87-fastUsdc branch February 19, 2025 21:45
mergify bot added a commit to Agoric/agoric-sdk that referenced this pull request Feb 20, 2025
evergreen

## Description
`b:beta-fast-usdc` became proposal 87 and made into a3p history with Agoric/agoric-3-proposals#220

This makes agoric-sdk a3p-integration base atop it.

### Security Considerations
none

### Scaling Considerations
none


### Documentation Considerations
none

### Testing Considerations
CI

### Upgrade Considerations
none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants