simplify CoreEval proposals #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turadg
force-pushed
the
ta/usability
branch
2 times, most recently
from
e241b6b to
9963d44
Compare
turadg
force-pushed
the
ta/simplify-coreeval
branch
from
26d3266 to
40c0cf6
Compare
turadg
commented
Jan 23, 2024
Chris-Hibbert
approved these changes
Jan 23, 2024
turadg
force-pushed
the
ta/simplify-coreeval
branch
from
40c0cf6 to
6602899
Compare
turadg
force-pushed
the
ta/simplify-coreeval
branch
from
6602899 to
88dd0da
Compare
|
When I restored the earlier packages, the refactorings didn't work without updating their dep on synthetic-chain. I didn't want to invalidate all those layers so I rolled back changes to earlier proposals. To validate that the synthetic-chain work I still updated That uncovered a couple bugs since the |
turadg
force-pushed
the
ta/simplify-coreeval
branch
3 times, most recently
from
e67cc7e to
8349972
Compare
turadg
force-pushed
the
ta/simplify-coreeval
branch
from
7dddf02 to
f88dd75
Compare
|
This CI run took 105m compared to 62m in the last PR, I don't see any changes that look suspicious so I suspect it's transient. I'm going to merge and keep an eye on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #21
Handles all the CoreEval proposal execution in the framework, so there's no longer an
eval.shor any proposal-specific code.What it abstracts is a little messy but I think the abstraction is right. The internals can be cleaned up later. I'm holding off on that until more of the use cases are fleshed out.