Skip to content

Commit

Permalink
ci(dependency-graph): remove packing artifacts from cache
Browse files Browse the repository at this point in the history
  • Loading branch information
michaelfig committed May 27, 2024
1 parent 0270908 commit 250c6ec
Showing 1 changed file with 15 additions and 7 deletions.
22 changes: 15 additions & 7 deletions .github/workflows/test-all-packages.yml
Original file line number Diff line number Diff line change
Expand Up @@ -60,13 +60,21 @@ jobs:
# Due to ambient types, certain build orders (from the dependency graph)
# may break the type resolution. Run this in the PR to find out before
# attempting to merge to master. This takes about 1min locally and since
# this job is about 30s in CI doing it here doesn't add to wall wait
# for CI resolution.
# We prepack only because full pack removes the declarations, relying on ambient
# resolution in the repo filesystem which will not be available when the packages
# are pulled from npm.
- name: Pack packages
run: yarn lerna run --reject-cycles --concurrency 1 prepack
# this job is about 30s in CI doing it here doesn't add to wall wait for
# CI resolution.
#
# We prepack only because full pack removes the declarations, relying on
# ambient resolution in the repo filesystem which will not be available
# when the packages are pulled from npm.
#
# After that test, we postpack to avoid putting the prepack artifacts in
# the cache maintained by restore-node, since they are not .gitignored and
# thus will fail restore-node's check for a clean repo when the cache is
# restored.
- name: Pack packages without ambient type resolution
run: |
yarn lerna run --reject-cycles --concurrency 1 prepack
yarn lerna run postpack
##################
# Lint tests
Expand Down

0 comments on commit 250c6ec

Please sign in to comment.