chore(ci): Make the Node versions in test matrix semantic (#11167)

closes: #11145

Updated the `test-all-packages` workflow to use semantic names in the engine matrix. This change will build up to smoothly transition between node version without affecting the required checks

None

None

None

The build should [pass](https://github.com/Agoric/agoric-sdk/actions/runs/14106899304)

None

Author: usmanmani1122

.github/actions/restore-node/action.yml

@@ -3,7 +3,7 @@ description: 'Set up Node.js environment and restore cached built files'
 
 inputs:
   node-version:
-    description: 'The version of Node.js to use'
+    description: 'The version or semantic name (node-old, node-new and xs supported) of Node.js to use'
     required: true
   path:
     description: 'The relative path to the agoric-sdk directory'
@@ -34,6 +34,27 @@ runs:
       shell: bash
       run: echo ESM_DISABLE_CACHE=true >> $GITHUB_ENV
 
+    - id: set-node-version
+      name: Set correct node version
+      shell: bash
+      run: |
+        set -o xtrace
+
+        VERSION_IDENTIFIER="${{ inputs.node-version }}"
+        OUTPUT_NODE_VERSION="$VERSION_IDENTIFIER"
+
+        if test "$VERSION_IDENTIFIER" == "node-new"
+        then
+          OUTPUT_NODE_VERSION="20"
+        else
+          if test "$VERSION_IDENTIFIER" == "node-old" || test "$VERSION_IDENTIFIER" == "xs"
+          then
+            OUTPUT_NODE_VERSION="18"
+          fi
+        fi
+
+        echo "NODE_VERSION=$OUTPUT_NODE_VERSION" >> "$GITHUB_OUTPUT"
+
     - uses: actions/checkout@v4
       with:
         clean: false
@@ -118,7 +139,7 @@ runs:
 
     - uses: actions/setup-node@v4
       with:
-        node-version: ${{ inputs.node-version }}
+        node-version: ${{ steps.set-node-version.outputs.NODE_VERSION }}
         cache: yarn
         cache-dependency-path: |
           ${{ inputs.path }}/yarn.lock
@@ -132,7 +153,7 @@ runs:
       uses: actions/cache@v4
       with:
         path: ${{ inputs.path }}
-        key: ${{ runner.os }}-${{ runner.arch }}-${{ steps.system-info.outputs.release }}-node-${{ inputs.node-version }}-built-${{ inputs.xsnap-random-init }}-${{ github.sha }}-${{ steps.endo-sha.outputs.sha }}
+        key: ${{ runner.os }}-${{ runner.arch }}-${{ steps.system-info.outputs.release }}-node-${{ steps.set-node-version.outputs.NODE_VERSION }}-built-${{ inputs.xsnap-random-init }}-${{ github.sha }}-${{ steps.endo-sha.outputs.sha }}
 
     # This and the git diff below are to detect if `yarn install` results in a
     # change to the lock file.

.github/workflows/after-merge.yml

@@ -16,7 +16,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: ['18.x', '20.x']
+        node-version: ['node-new', 'node-old']
     steps:
       - uses: actions/checkout@v4
         with:
@@ -39,7 +39,7 @@ jobs:
     strategy:
       matrix:
         # note: only use one node-version
-        node-version: ['18.x']
+        node-version: ['node-old']
     steps:
       - uses: actions/checkout@v4
       - uses: ./.github/actions/restore-node
@@ -97,7 +97,7 @@ jobs:
     strategy:
       matrix:
         # note: only use one node-version
-        node-version: ['18.x']
+        node-version: ['node-old']
     if: ${{github.event_name == 'push' }}
     steps:
       - uses: actions/checkout@v4
@@ -139,7 +139,7 @@ jobs:
     strategy:
       matrix:
         # note: only use one node-version
-        node-version: ['18.x']
+        node-version: ['node-old']
     if: ${{github.event_name == 'push'}}
     steps:
       - uses: actions/checkout@v4

.github/workflows/benchmarks.yml

@@ -21,7 +21,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: ./.github/actions/restore-node
         with:
-          node-version: '18.x'
+          node-version: 'node-old'
 
       - name: yarn bench (boot)
         shell: bash

.github/workflows/integration.yml

@@ -259,12 +259,16 @@ jobs:
         working-directory: packages/deployment
       - uses: ./.github/actions/restore-node
         with:
-          node-version: '18.x'
           # Rebuilding the SDK image with resolved endo packages is not currently supported
           # and since we can't build core eval submissions from the SDK using a newer endo,
           # simply ignore any endo branch integration (this means we don't have full coverage)
           ignore-endo-branch: 'true'
-        id: restore-node
+          node-version: 'node-old'
+          path: ./agoric-sdk
+          # Forces xsnap to initialize all memory to random data, which increases
+          # the chances the content of snapshots may deviate between validators
+          xsnap-random-init: '1'
+
       - name: setup a3p-integration
         run: yarn install
         working-directory: a3p-integration

.github/workflows/multichain-e2e-template.yml

@@ -29,7 +29,7 @@ jobs:
 
       - uses: ./agoric-sdk/.github/actions/restore-node
         with:
-          node-version: 18.x
+          node-version: 'node-old'
           path: ./agoric-sdk
 
       # Extract chain and relayer information