Skip to content

Commit

Permalink
Merge pull request #9055 from Agoric/gibson-9054-core-eval-handler-co…
Browse files Browse the repository at this point in the history
…mments

chore: Update comments referencing core eval handling
  • Loading branch information
mergify[bot] authored Mar 11, 2024
2 parents 177a8d0 + 4e5ef18 commit c731c8c
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion golang/cosmos/proto/agoric/swingset/swingset.proto
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ option go_package = "github.com/Agoric/agoric-sdk/golang/cosmos/x/swingset/types

// CoreEvalProposal is a gov Content type for evaluating code in the SwingSet
// core.
// See `agoric-sdk/packages/vats/src/core/eval.js`.
// See `bridgeCoreEval` in agoric-sdk packages/vats/src/core/chain-behaviors.js.
message CoreEvalProposal {
option (gogoproto.goproto_getters) = false;

Expand Down
2 changes: 1 addition & 1 deletion golang/cosmos/x/swingset/types/swingset.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/cosmic-proto/proto/agoric/swingset/swingset.proto
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ option go_package = "github.com/Agoric/agoric-sdk/golang/cosmos/x/swingset/types

// CoreEvalProposal is a gov Content type for evaluating code in the SwingSet
// core.
// See `agoric-sdk/packages/vats/src/core/eval.js`.
// See `bridgeCoreEval` in agoric-sdk packages/vats/src/core/chain-behaviors.js.
message CoreEvalProposal {
option (gogoproto.goproto_getters) = false;

Expand Down
6 changes: 3 additions & 3 deletions packages/cosmic-proto/src/codegen/agoric/swingset/swingset.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { isSet, bytesFromBase64, base64FromBytes } from '../../helpers.js';
/**
* CoreEvalProposal is a gov Content type for evaluating code in the SwingSet
* core.
* See `agoric-sdk/packages/vats/src/core/eval.js`.
* See `bridgeCoreEval` in agoric-sdk packages/vats/src/core/chain-behaviors.js.
*/
export interface CoreEvalProposal {
title: string;
Expand All @@ -27,7 +27,7 @@ export interface CoreEvalProposalProtoMsg {
/**
* CoreEvalProposal is a gov Content type for evaluating code in the SwingSet
* core.
* See `agoric-sdk/packages/vats/src/core/eval.js`.
* See `bridgeCoreEval` in agoric-sdk packages/vats/src/core/chain-behaviors.js.
*/
export interface CoreEvalProposalAmino {
title?: string;
Expand All @@ -45,7 +45,7 @@ export interface CoreEvalProposalAminoMsg {
/**
* CoreEvalProposal is a gov Content type for evaluating code in the SwingSet
* core.
* See `agoric-sdk/packages/vats/src/core/eval.js`.
* See `bridgeCoreEval` in agoric-sdk packages/vats/src/core/chain-behaviors.js.
*/
export interface CoreEvalProposalSDKType {
title: string;
Expand Down
2 changes: 1 addition & 1 deletion packages/vats/src/core/README.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Core vats and supports

This directory contains modules that build vats that boot other vats. If that's all it did, it could terminate but it also has persistent responsibilities:
- hold the `CORE_EVAL` bridge handler
- hold the `CORE_EVAL` bridge handler (see `bridgeCoreEval` in [chain-behaviors.js](./chain-behaviors.js)
- hold a PrioritySenderManager handed out to some contracts

Bootstrap vats must not hold precious state (see https://github.com/Agoric/agoric-sdk/issues/4548). These state aren't _precious_ because they can be reconstructed.
Expand Down

0 comments on commit c731c8c

Please sign in to comment.