Skip to content

Commit

Permalink
chore: reinstate wallet in upgrade.go (#10350)
Browse files Browse the repository at this point in the history
refs: #9404 
refs: #10336
refs: #10319



## Description

#10319 cleaned up some dead code in smartWallets, and expected the changes to be included in Upgrade 18, because the smartWallet proposal was included in `upgrade.go`. #10336 cleaned up proposals that were left over from Upgrade 17. This reinstates the upgrade for wallets.

### Security Considerations

The cleaned up code is benign. it was designed to run once and has served its purpose. Removing it shouldn't affect anything.

### Scaling Considerations

No scaling consequences.

### Documentation Considerations

None

### Testing Considerations

The wallet upgrade was included in A3P-integration testing until three days ago. #10319 has been tested since 5 days ago without incident. removing benign dead code doesn't require extra tests.

### Upgrade Considerations

There is no *requirement* that this change be included in U18, so if it causes problems or gives anyone the willies, it can wait for the next release, but it's ready now.
  • Loading branch information
Chris-Hibbert authored Oct 29, 2024
1 parent 745d557 commit ced5d49
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
2 changes: 1 addition & 1 deletion a3p-integration/proposals/n:upgrade-next/initial.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const vats = {
localchain: { incarnation: 1 },
orchestration: { incarnation: 0 },
transfer: { incarnation: 1 },
walletFactory: { incarnation: 4 },
walletFactory: { incarnation: 5 },
zoe: { incarnation: 3 },
};

Expand Down
4 changes: 4 additions & 0 deletions golang/cosmos/app/upgrade.go
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,10 @@ func unreleasedUpgradeHandler(app *GaiaApp, targetUpgrade string) func(sdk.Conte
vm.CoreProposalStepForModules(
"@agoric/builders/scripts/vats/revive-kread.js",
),
vm.CoreProposalStepForModules(
// Upgrade to include a cleanup from https://github.com/Agoric/agoric-sdk/pull/10319
"@agoric/builders/scripts/smart-wallet/build-wallet-factory2-upgrade.js",
),
}
}

Expand Down

0 comments on commit ced5d49

Please sign in to comment.