chore: implement failing IBC msg test case

Refs: #8863

Author: anilhelvaci

multichain-testing/test/xcs-swap-anything/swap-anything.test.ts

@@ -11,6 +11,7 @@ import {
   makeIBCTransferMsg,
 } from '../../tools/ibc-transfer.js';
 import { makeHttpClient } from '../../tools/makeHttpClient.js';
+import type { OfferStatus } from '@agoric/smart-wallet/src/offers.js';
 import {
   fundRemote,
   setupXcsContracts,
@@ -341,6 +342,87 @@ test.serial('BLD for OSMO, receiver on CosmosHub', async t => {
   );
 });
 
+test.serial('BLD for OSMO, receiver chain not registered to XCS, should throw', async t => {
+  const {
+    wallets,
+    provisionSmartWallet,
+    vstorageClient,
+    retryUntilCondition,
+    useChain,
+  } = t.context;
+
+  // Provision the Agoric smart wallet
+  const agoricAddr = wallets.agoricSender;
+  const wdUser = await provisionSmartWallet(agoricAddr, {
+    BLD: 1000n,
+    IST: 1000n,
+  });
+  t.log(`Provisioned Agoric smart wallet for ${agoricAddr}`);
+
+  const apiUrl = await useChain('agoric').getRestEndpoint();
+  const queryClient = makeQueryClient(apiUrl);
+
+  const brands = await vstorageClient.queryData('published.agoricNames.brand');
+  const bldBrand = Object.fromEntries(brands).BLD;
+  const swapInAmount = AmountMath.make(bldBrand, 125n);
+  const { balance: bldBalanceBefore } = await queryClient.queryBalance(
+    agoricAddr,
+    'ubld',
+  );
+
+  // Send swap offer
+  const makeAccountOfferId = `swap-ubld-uosmo-${Date.now()}`;
+  const updates = wdUser.offers.executeOffer({
+    id: makeAccountOfferId,
+    invitationSpec: {
+      source: 'agoricContract',
+      instancePath: [contractName],
+      callPipe: [['makeSendInvitation']],
+    },
+    offerArgs: {
+      // TODO: get the contract address dynamically
+      destAddr:
+        'osmo17p9rzwnnfxcjp32un9ug7yhhzgtkhvl9jfksztgw5uh69wac2pgs5yczr8',
+      receiverAddr: 'noble/noble1foo',
+      outDenom: 'uosmo',
+      slippage: { slippagePercentage: '20', windowSeconds: 10 },
+      onFailedDelivery: 'do_nothing',
+    },
+    proposal: { give: { Send: swapInAmount } },
+  });
+
+  const {
+    // @ts-expect-error types
+    value: {
+      status: { error: errorMsg },
+    },
+  } = await retryUntilCondition(
+    // Prevent test from hanging when no new values are coming from updates.next()
+    () =>
+      Promise.race([
+        updates.next(),
+        new Promise(resolve =>
+          setTimeout(async () => {
+            await updates.return();
+            resolve('Done');
+          }, 5000),
+        ),
+      ]),
+    (result: { value: { updated: string; status: OfferStatus } }) => {
+      return result.value.status.error !== undefined;
+    },
+    'Offer result did not fail as expect ed',
+  );
+
+  const { balance: bldBalanceAfter } = await queryClient.queryBalance(
+    agoricAddr,
+    'ubld',
+  );
+
+  t.deepEqual(bldBalanceBefore, bldBalanceAfter);
+  t.regex(errorMsg, /^Error: IBC Transfer failed/);
+});
+
 /**
  * UNTIL https://github.com/Agoric/BytePitchPartnerEng/issues/51, we are skipping this
  * until the ticket above is done

packages/orchestration/src/examples/swap-anything.contract.js

@@ -51,8 +51,8 @@ export const contract = async (
   // UNTIL https://github.com/Agoric/agoric-sdk/issues/9066
   const logNode = E(privateArgs.storageNode).makeChildNode('log');
   /** @type {(msg: string) => Vow<void>} */
-  const log = msg =>
-    vowTools.watch(E(logNode).setValue(JSON.stringify({ msg })));
+  const log = (msg, level = 'info') =>
+    vowTools.watch(E(logNode).setValue(JSON.stringify({ msg, level })));
 
   const makeLocalAccount = orchestrate(
     'makeLocalAccount',

packages/orchestration/src/examples/swap-anything.flows.js

@@ -70,7 +70,7 @@ const buildXCSMemo = swapInfo => {
  * @param {GuestInterface<ChainHub>} ctx.chainHub
  * @param {Promise<GuestInterface<LocalOrchestrationAccountKit['holder']>>} ctx.sharedLocalAccountP
  * @param {GuestInterface<ZoeTools>} ctx.zoeTools
- * @param {GuestOf<(msg: string) => Vow<void>>} ctx.log
+ * @param {GuestOf<(msg: string, level?: string) => Vow<void>>} ctx.log
  * @param {ZCFSeat} seat
  * @param {SwapInfo} offerArgs
  */
@@ -124,6 +124,7 @@ export const swapIt = async (
     await withdrawToSeat(sharedLocalAccount, seat, give);
     const errorMsg = `IBC Transfer failed ${q(e)}`;
     trace(`ERROR: ${errorMsg}`);
+    void log(errorMsg, 'error');
     seat.fail(errorMsg);
     throw makeError(errorMsg);
   };
@@ -142,6 +143,7 @@ export const swapIt = async (
   try {
     const memo = buildXCSMemo(offerArgs);
     trace(memo);
+    void log(`sending transfer with ${q(memo)}`);
 
     await sharedLocalAccount.transfer(
       {
@@ -154,6 +156,7 @@ export const swapIt = async (
     );
     trace(`completed transfer to ${destAddr}`);
   } catch (e) {
+    void log(`transfer error ${q(e)}`, 'error');
     return recoverFailedTransfer(e);
   }