Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI for FU Liquidity Provider #10328

Closed
turadg opened this issue Oct 23, 2024 · 1 comment · Fixed by #10636
Closed

CLI for FU Liquidity Provider #10328

turadg opened this issue Oct 23, 2024 · 1 comment · Fixed by #10636
Assignees
Labels
enhancement New feature or request

Comments

@turadg
Copy link
Member

turadg commented Oct 23, 2024

What is the Problem Being Solved?

Description of the Design

deposit command that does the public invitation maker. (for now whoever deposits first gets the sole right to withdraw)
withdraw command to withdraw deposits

Does not do anything for "requesting advance". @samsiegart is working on that.

Security Considerations

Scaling Considerations

Test Plan

Upgrade Considerations

@turadg turadg self-assigned this Oct 23, 2024
mergify bot added a commit that referenced this issue Oct 23, 2024
refs: #10328

## Description
Sets up a package for Fast USDC and stubs out its CLI.

Finishing #10328 will require a contract that has the offer makers.

### Security Considerations
none

### Scaling Considerations
none


### Documentation Considerations
This will need end user documentation later

### Testing Considerations
basic test

### Upgrade Considerations
not deployed
mergify bot added a commit that referenced this issue Oct 30, 2024
refs: #10328 

## Description
Following up on package creation. See changes in commit list. Principally renaming the package to have the `@agoric/` prefix.

### Security Considerations
`@agoric/` could reduce NPM squatting risk

### Scaling Considerations
n/a

### Documentation Considerations
none

### Testing Considerations
one

### Upgrade Considerations
not deployable
@turadg turadg assigned samsiegart and unassigned turadg Nov 4, 2024
@LuqiPan LuqiPan added the enhancement New feature or request label Dec 2, 2024
mergify bot added a commit that referenced this issue Dec 10, 2024
closes: #10657 
refs: #10328

## Description

 - advancer, settler can operate without a noble account address
 - creatorFacet method to synchronize on fulfillment of `nobleAccountV` vow
 - restore fast-usdc a3p-integration test to working order

### Security / Documentation Considerations

While the noble account vow has not fulfilled, diagnostics for advancing to non-agoric chains are likely to be obscure.

Configuration flexibility leads to possibility of configuration errors.

### Scaling Considerations

n/a

### Testing Considerations

existing tests, but with `set -e` so that when `fastUsdc` is not in `agoricNames.instance`, we actually notice.

### Upgrade Considerations

`nobleAccountV` persists across incarnations, so we won't try to make another one on restart / upgrade.

TODO:
 - [x] what to do if `nobleAccountV` rejects?
@dckc
Copy link
Member

dckc commented Dec 10, 2024

Also fix up the "description" package.json of fast-usdc

was done in #10364

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants