Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ci job to verify package.json shape #11048

Open
mhofman opened this issue Feb 25, 2025 · 0 comments
Open

Ci job to verify package.json shape #11048

mhofman opened this issue Feb 25, 2025 · 0 comments
Labels
enhancement New feature or request tooling repo-wide infrastructure

Comments

@mhofman
Copy link
Member

mhofman commented Feb 25, 2025

What is the Problem Being Solved?

Publishing with lerna updates the version and intra repo deps of each package.json. That operation normalizes the package.json by at least sorting the deps and removing empty dep / devDeps.

The diff generated by the publishing process should be as minimal as possible and only contain version bumps to make it easier to merge back changes in the future (partially described in #9490)

Description of the Design

A CI job that replicates some of the lerna package.json normalization and verifies that it doesn't result in a dirty worktree (could rely on existing check or be explicit)

Security Considerations

None

Scaling Considerations

None

Test Plan

Manual?

Upgrade Considerations

None

@mhofman mhofman added enhancement New feature or request tooling repo-wide infrastructure labels Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tooling repo-wide infrastructure
Projects
None yet
Development

No branches or pull requests

1 participant