cleanup fast-usdc package #10364
Merged
cleanup fast-usdc package #10364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
202ba1e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://824bc029.agoric-sdk.pages.dev |
| Branch Preview URL: | https://ta-fu-package-cleanup.agoric-sdk.pages.dev |
michaelfig
approved these changes
Oct 29, 2024
This comment was marked as outdated.
This comment was marked as outdated.
michaelfig
reviewed
Oct 30, 2024
packages/fast-usdc/package.json
Outdated
| @@ -2,7 +2,7 @@ | |||
| "name": "fast-usdc", | |||
There was a problem hiding this comment.
Oh. Didn't you mean to change this?
Suggested change
| "name": "fast-usdc", | |
| "name": "@agoric/fast-usdc", |
There was a problem hiding this comment.
lol, I did mean to! 139d42b
breaking changes not applicable https://github.com/tj/commander.js/releases/tag/v12.0.0
turadg
force-pushed
the
ta/fu-package-cleanup
branch
from
139d42b to
33309e0
Compare
discount-step was defined twice. This picks the more documented one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #10328
Description
Following up on package creation. See changes in commit list. Principally renaming the package to have the
@agoric/prefix.Security Considerations
@agoric/could reduce NPM squatting riskScaling Considerations
n/a
Documentation Considerations
none
Testing Considerations
one
Upgrade Considerations
not deployable