Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: make durable Orch tests able to run concurrently #10381

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

turadg
Copy link
Member

@turadg turadg commented Oct 31, 2024

incidental

Description

Some orchestration tests were serialized to work around reincarnate hacks around setupZCFTest that wasn't compatible with durable baggage. E.g. fakeVatAdmin and its bundle caps were not durable.

The test don't need a full ZCF, so this instead creates a fake one. It also refactors the reincarnation so only modules that need durability get it (and just once).

The upshot is that none of these tests need to be .serial now.

Security Considerations

none

Scaling Considerations

none

Documentation Considerations

none

Testing Considerations

none

Upgrade Considerations

none

@turadg turadg requested a review from a team as a code owner October 31, 2024 17:36
@turadg turadg changed the title test: make durable tests able to run concurrently test: make durable Orch tests able to run concurrently Oct 31, 2024
Copy link

cloudflare-workers-and-pages bot commented Oct 31, 2024

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: ea569e8
Status: ✅  Deploy successful!
Preview URL: https://f45f77eb.agoric-sdk.pages.dev
Branch Preview URL: https://ta-parallel-orch-tests.agoric-sdk.pages.dev

View logs

@mhofman

This comment was marked as off-topic.

@turadg turadg requested review from michaelfig and removed request for mhofman October 31, 2024 22:45
Copy link
Member

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, this simplification is a good one that enables durability testing. It specifically does not test vat upgrade, but that is done in the bootstrap/RunUtils tests.

LGTM!

@turadg turadg force-pushed the ta/parallel-orch-tests branch from e11c2a6 to ea569e8 Compare November 1, 2024 15:13
@turadg turadg added the automerge:rebase Automatically rebase updates, then merge label Nov 1, 2024
@mergify mergify bot merged commit 5429b84 into master Nov 1, 2024
90 checks passed
@mergify mergify bot deleted the ta/parallel-orch-tests branch November 1, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants