refactor(a3p-integration): Document and clean up core-eval generation #10466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
c0c5b84
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3d18db68.agoric-sdk.pages.dev |
| Branch Preview URL: | https://gibson-2024-11-cleanup-a3p-i.agoric-sdk.pages.dev |
michaelfig
approved these changes
Nov 13, 2024
gibson042
force-pushed
the
gibson-2024-11-cleanup-a3p-integration
branch
from
4372104 to
f4ef2ec
Compare
mergify bot
added a commit
that referenced
this pull request
Nov 13, 2024
## Description Fixing some issues noticed while working on #10466. ### Security Considerations n/a ### Scaling Considerations n/a ### Documentation Considerations :heavy_check_mark: ### Testing Considerations n/a ### Upgrade Considerations n/a
…e.json "agoricProposal" Also document build-all-submissions.sh w.r.t. `./proposals?:*`.
gibson042
force-pushed
the
gibson-2024-11-cleanup-a3p-integration
branch
from
f4ef2ec to
c0c5b84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolving some confusion I experienced while debugging #10165 and working on #10446.
./proposals/?:*Security Considerations
None known.
Scaling Considerations
n/a
Documentation Considerations
Included in the README and shell scripts.
Testing Considerations
These scripts are covered by integration testing.
Upgrade Considerations
None known; a3p-integration should be self-contained.