misc Fast USDC cleanup #10970
Merged
misc Fast USDC cleanup #10970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
00d146d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://64203fb4.agoric-sdk.pages.dev |
| Branch Preview URL: | https://ta-fu-misc.agoric-sdk.pages.dev |
dckc
approved these changes
Feb 10, 2025
| // XXX even 15 wasn't enough | ||
| const SMART_WALLET_PROVISION_RETRIES = 30; | ||
| // XXX also tried 15, 30. There's probably something deeper to fix. | ||
| const SMART_WALLET_PROVISION_RETRIES = 100; |
There was a problem hiding this comment.
has a higher retry count ever helped?
my intuition says that the thing gets into a state where just retrying won't help.
There was a problem hiding this comment.
I think so but since it's intermittent it's hard to know for sure. If 100 doesn't work then I'll take a different tack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #9934
Description
Increases the threshold for multichain that has been timing out (à la #9934)
Also includes a couple tiny improvements to docs and logging.
Security Considerations
Scaling Considerations
Documentation Considerations
Testing Considerations
Upgrade Considerations