chore(fast-usdc): update, test chain policies vs. spreadsheet #11055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
5469f90
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1aaefbbf.agoric-sdk.pages.dev |
| Branch Preview URL: | https://dc-fu-policy-check.agoric-sdk.pages.dev |
dckc
force-pushed
the
dc-fu-policy-check
branch
from
d0e4d8c to
e677e98
Compare
dckc
force-pushed
the
dc-fu-policy-check
branch
2 times, most recently
from
ab8149d to
4cab2bf
Compare
dckc
force-pushed
the
dc-fu-policy-check
branch
from
4cab2bf to
96fdf1a
Compare
turadg
approved these changes
Feb 28, 2025
| @@ -241,7 +241,7 @@ test.serial( | |||
| }, | |||
| ); | |||
|
|
|||
| test.serial('writes feed policy to vstorage', async t => { | |||
| test.skip('writes Beta feed policy to vstorage', async t => { | |||
There was a problem hiding this comment.
shouldn't we remove them now that beta is out?
There was a problem hiding this comment.
ok.
I guess I wanted some feedback on whether to keep testing the old stuff. Thanks.
| /** | ||
| * @type {TypedPattern<FeedPolicy>} | ||
| * | ||
| * Should be JSON serializable so CLI can specify policy. E.g. no bigint, |
There was a problem hiding this comment.
IIUC bigint is the only part that can't be JSON.
consider keeping this comment and saying "must by CopyData"
| const upgraded = await E(adminFacet).upgradeContract( | ||
| fastUsdcCode.bundleID, | ||
| privateArgs, | ||
| ); | ||
| trace(upgraded); | ||
| trace(`DON'T PANIC if you see "CORE_EVAL failed" from v1 above. See #11013`); |
| import { ChainPolicies } from '../../src/utils/chain-policies.js'; | ||
| import { type ChainPolicy } from '../../src/types.js'; | ||
|
|
||
| /** Spreadsheet header becomes a tuple type with column names used as tags */ |
There was a problem hiding this comment.
good trail. I won't have the spreadsheet so I'll assume you transcribed the values correctly.
| ['Polygon', 2, 12, '$50,000', 60, '$20,000'], | ||
| ]; | ||
|
|
||
| type Money = string; |
There was a problem hiding this comment.
Suggested change
| type Money = string; | |
| type Dollars = `${string}`; |
dckc
force-pushed
the
dc-fu-policy-check
branch
from
f20e3c9 to
7150132
Compare
rate limits have bigints
dckc
force-pushed
the
dc-fu-policy-check
branch
from
7150132 to
5469f90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Data from a requirements-gathering spreadsheet are turned into a test that shows that the
MAINNETchain policies needed adjustment.Security Considerations
The values in a
ChainPolicyexpress a balance of risk tolerance vs. speed etc.agoric-sdk/packages/fast-usdc/src/types.ts
Line 114 in f83e5a9
Scaling Considerations
none
Documentation Considerations
Testing Considerations
Upgrade Considerations
should be deployed as part of the fix for #11013