fix: minted early tracking #11066

0xpatrickdev · 2025-02-28T02:18:25Z

Description

Ensures the mintedEarly store can track multiple settlements for the same amount from the same address.

Security Considerations

Ensures state diagram invariants are upheld.

Scaling Considerations

Same considerations as #10729 - the mapStore could grow large if an attacker spams the settlementAccount with uusdc. In these changes we ensure to delete map store entries when the count goes to 0.

Documentation Considerations

Changes should be clear to maintainers.

Testing Considerations

Adds a new test for the scenario not originally considered.

Upgrade Considerations

The mintedEarly kind is a Remotable, so changing from a SetStore to a MapStore does not seem to affect upgradability.

These change should be included in the FUSDC GTM CE.

turadg

Good test.

We should have a multiset abstraction. Either with durable multiset or a light wrapper to make MapStore act like one.

packages/fast-usdc/src/exos/settler.js

cloudflare-workers-and-pages · 2025-02-28T19:22:49Z

Deploying agoric-sdk with Cloudflare Pages

Latest commit:	`5597958`
Status:	✅ Deploy successful!
Preview URL:	https://a55f4145.agoric-sdk.pages.dev
Branch Preview URL:	https://pc-minted-early-fix.agoric-sdk.pages.dev

View logs

turadg

@0xpatrickdev I pushed the changes I requested but I won't merge. PTAL

mhofman · 2025-02-28T19:27:30Z

packages/fast-usdc/src/utils/store.js

+      if (count <= 0) {
+        throw Fail`Cannot add a non-positive count ${count} to bag`;
+      }


Probably should check that count is a Nat ?

I'm using number and Nat is bigint

Sure, but we should still enforce that this in an integer, not any float.

Actually it's not just floats, but any NaN or non number values that will cause unexpected value for current count.

mhofman · 2025-02-28T19:28:19Z

packages/fast-usdc/src/utils/store.js

+      if (currentCount <= count) {
+        mapStore.delete(item);


Feels like removing more than what is currently there should be an error.

it's returning a success boolean. we can align on this when moved to another package.

Asking to remove 5 from an entry that only has 3 still returns true, which seems incorrect.

Revised: https://github.com/Agoric/agoric-sdk/compare/3e5eaec79bb4c246acefa5d279863cd0d98e0b5f..55979584e7e080cdf444f85a1228b1ce5f69074b

mergify · 2025-02-28T23:11:47Z

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

❌ integration-test-result
☑️ linear-history

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

mergify · 2025-03-01T00:27:40Z

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

❌ integration-test-result
☑️ linear-history

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

- ensure multiples of the same NFA+amount are tracked

- `borrower.returnPool` already exits the seat

mergify · 2025-03-01T17:22:08Z

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

❌ integration-test-result
☑️ linear-history

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

### Description Cherrypicks the following changes: - #11065 - #11052 Using the following rebase-todo: ``` # PR #11065 Branch fix-cosmos-upgrade-to-agoric-labs-ibc-go-v6-3-1-alpha-agoric-3-11065- label base-fix-cosmos-upgrade-to-agoric-labs-ibc-go-v6-3-1-alpha-agoric-3-11065- pick 52fb6cf build(deps): use new version of ibc-go pick 3dbb1bc chore(golang): `go mod tidy` label pr-11065--fix-cosmos-upgrade-to-agoric-labs-ibc-go-v6-3-1-alpha-agoric-3-11065- reset base-fix-cosmos-upgrade-to-agoric-labs-ibc-go-v6-3-1-alpha-agoric-3-11065- merge -C ee18609 pr-11065--fix-cosmos-upgrade-to-agoric-labs-ibc-go-v6-3-1-alpha-agoric-3-11065- # fix(cosmos): upgrade to `agoric-labs/ibc-go` `v6.3.1-alpha.agoric.3` (#11065) # PR #11052 Branch fix-Properly-synchronize-slog-sender-termination-11052- label base-fix-Properly-synchronize-slog-sender-termination-11052- pick ec3c1a2 chore(SwingSet): Remove unused code and comments pick 9ab1630 fix(SwingSet): Include level in kernel console slog output pick fcfb944 refactor(SwingSet): Simplify makeFinishersKit into addSlogCallbacks pick d8a5947 refactor(SwingSet): Improve addSlogCallbacks parameter/variable names pick f83c01d fix: Properly synchronize slog sender termination pick 318269e chore(telemetry): Use more readable async patterns pick fa1f04a chore(SwingSet): Prefer type Callable over Function pick 117c766 fix(internal): Exempt process.stdout from being closed by makeFsStreamWriter pick 6c6fba4 refactor(internal): Prefer fs.WriteStream close() over stream.Writable end() label pr-11052--fix-Properly-synchronize-slog-sender-termination-11052- reset base-fix-Properly-synchronize-slog-sender-termination-11052- # fix: minted early tracking (#11066) merge -C 42d5764 pr-11052--fix-Properly-synchronize-slog-sender-termination-11052- # fix: Properly synchronize slog sender termination (#11052) ```

0xpatrickdev requested a review from a team as a code owner February 28, 2025 02:18

0xpatrickdev requested review from AgoricTriage and turadg February 28, 2025 02:18

0xpatrickdev self-assigned this Feb 28, 2025

turadg requested changes Feb 28, 2025

View reviewed changes

packages/fast-usdc/src/exos/settler.js Outdated Show resolved Hide resolved

packages/fast-usdc/src/exos/settler.js Outdated Show resolved Hide resolved

packages/fast-usdc/src/exos/settler.js Outdated Show resolved Hide resolved

turadg force-pushed the pc/minted-early-fix branch from c8ec060 to 400b37b Compare February 28, 2025 19:22

turadg approved these changes Feb 28, 2025

View reviewed changes

mhofman reviewed Feb 28, 2025

View reviewed changes

turadg force-pushed the pc/minted-early-fix branch from 400b37b to ca5ae30 Compare February 28, 2025 22:29

turadg added the automerge:rebase Automatically rebase updates, then merge label Feb 28, 2025

0xpatrickdev force-pushed the pc/minted-early-fix branch from ca5ae30 to 6c3832a Compare February 28, 2025 23:42

chore: undupe isCopyMap, isCopySet

cf7e623

0xpatrickdev force-pushed the pc/minted-early-fix branch from b3af0a0 to 3e5eaec Compare March 1, 2025 16:28

turadg and others added 3 commits March 1, 2025 11:37

feat: asMultiset

cb48d59

fix: minted early tracking

bc7d042

- ensure multiples of the same NFA+amount are tracked

fix: "seat has been exited"

5597958

- `borrower.returnPool` already exits the seat

0xpatrickdev force-pushed the pc/minted-early-fix branch from 3e5eaec to 5597958 Compare March 1, 2025 16:37

mergify bot merged commit 92714b3 into master Mar 1, 2025
84 checks passed

mergify bot deleted the pc/minted-early-fix branch March 1, 2025 17:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: minted early tracking #11066

fix: minted early tracking #11066

0xpatrickdev commented Feb 28, 2025 •

edited

Loading

turadg left a comment

cloudflare-workers-and-pages bot commented Feb 28, 2025 •

edited

Loading

turadg left a comment

mhofman Feb 28, 2025

turadg Feb 28, 2025

mhofman Mar 1, 2025

mhofman Mar 1, 2025

mhofman Feb 28, 2025

turadg Feb 28, 2025

mhofman Mar 1, 2025

0xpatrickdev Mar 1, 2025

mergify bot commented Feb 28, 2025

mergify bot commented Mar 1, 2025

mergify bot commented Mar 1, 2025

fix: minted early tracking #11066

fix: minted early tracking #11066

Conversation

0xpatrickdev commented Feb 28, 2025 • edited Loading

Description

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

Upgrade Considerations

turadg left a comment

Choose a reason for hiding this comment

cloudflare-workers-and-pages bot commented Feb 28, 2025 • edited Loading

Deploying agoric-sdk with Cloudflare Pages

turadg left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mergify bot commented Feb 28, 2025

mergify bot commented Mar 1, 2025

mergify bot commented Mar 1, 2025

0xpatrickdev commented Feb 28, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Feb 28, 2025 •

edited

Loading