improve error handling #11070
Merged
improve error handling #11070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
741be79
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://df9806b2.agoric-sdk.pages.dev |
| Branch Preview URL: | https://10968-audit-error-handling.agoric-sdk.pages.dev |
dckc
approved these changes
Mar 1, 2025
|
I presume "closes: #10968" is appropriate; for tracking purposes, I went ahead and added it to the description. |
turadg
commented
Mar 1, 2025
turadg
force-pushed
the
10968-audit-error-handling
branch
from
1bfd098 to
5fe02af
Compare
dckc
approved these changes
Mar 3, 2025
| store.delete(txHash); | ||
|
|
||
| if (found.length === pending.getSize()) { | ||
| // all have reported so clean up |
There was a problem hiding this comment.
so clean-up depends on availability of all operators.
doesn't seem ideal, but seems workable for the coming release.
| await E(txNode).setValue(JSON.stringify(capData)); | ||
| // Don't await, just writing to vstorage. | ||
| void E.when(E(marshaller).toCapData(record), capData => | ||
| E(txNode).setValue(JSON.stringify(capData)), |
There was a problem hiding this comment.
I wonder if we should be using...
Suggested change
| E(txNode).setValue(JSON.stringify(capData)), | |
| E.sendOnly(txNode).setValue(JSON.stringify(capData)), |
I don't see any other use of it in agoric-sdk production code, though.
Comment on lines
+163
to
+164
| pending.delete(operatorId); | ||
| risks.delete(operatorId); |
There was a problem hiding this comment.
I suppose this change is covered by the revised remove operator test, though I haven't studied it well enough to be certain.
Comment on lines
+227
to
+232
| // one attestation is now sufficient (half of two) but the only evidence was just removed | ||
| await eventLoopIteration(); | ||
| t.falsy(published); | ||
| op2.operator.submitEvidence(evidence); | ||
| await eventLoopIteration(); | ||
| t.deepEqual(published, evidence); |
Comment on lines
-3251
to
-3255
| '0x000002': {}, | ||
| '0x000003': {}, | ||
| '0x000004': {}, | ||
| '0x000005': {}, | ||
| '0x000006': {}, |
There was a problem hiding this comment.
so the lack of clean-up was visible right here in the snapshot? interesting.
Before this each third attest was treated as a new transaction
turadg
force-pushed
the
10968-audit-error-handling
branch
from
5fe02af to
741be79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #10968
Description
feat: clean up upon last attest
feat: check conflicting evidence before quorum
chore: clean up promise handling
replace debug() with trace() in PacketTools
docs: TxFeed does not inspect evidence
test: self disagreement
Security Considerations
slightly stricter check
Scaling Considerations
reduces growth of TxFeed's
pendingstore (which would always have the third operator submission)Documentation Considerations
some new docs
Testing Considerations
some new tests
Upgrade Considerations
Fully backwards compatible