chore(cosmos): map devnet config to mainnet upgrade name for upgrading devnet to u19 #11316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
e960d6e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0eff7d29.agoric-sdk.pages.dev |
| Branch Preview URL: | https://mk-devnet-intermediary.agoric-sdk.pages.dev |
|
This PR should not get merged, but is ok to have a devnet specific commit living on a branch offshoot. Unfortunately we risk issues because the upgrade info referenced the release commit without this patch, we'll need to communicated this clearly. Please rebase this branch to clean it up, then we can upgrade devnet to it. |
|
Maybe we should target a |
mujahidkay
changed the base branch from
dev-upgrade-19
to
dev-upgrade-19-devnet
mujahidkay
force-pushed
the
mk/devnet-intermediary
branch
2 times, most recently
from
1104a6e to
709dcdb
Compare
|
No dependency changes detected. Learn more about Socket for GitHub. 👍 No dependency changes detected in pull request |
mujahidkay
force-pushed
the
mk/devnet-intermediary
branch
from
709dcdb to
dd74834
Compare
mujahidkay
added
force:integration
mujahidkay
force-pushed
the
mk/devnet-intermediary
branch
3 times, most recently
from
a91fcb7 to
0fc016a
Compare
mhofman
reviewed
Apr 24, 2025
.github/workflows/integration.yml
Outdated
| path: ./agoric-sdk | ||
| # Forces xsnap to initialize all memory to random data, which increases | ||
| # the chances the content of snapshots may deviate between validators | ||
| xsnap-random-init: '1' |
There was a problem hiding this comment.
I think this may be the problem. I don't think it should be in this cherry pick
mujahidkay
force-pushed
the
mk/devnet-intermediary
branch
2 times, most recently
from
25d0a57 to
e960d6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade proposal with incorrect upgrade name was passed on devnet (using
agoric-upgrade-19-mainnet). This PR maps mainnet upgrade name to devnet variant config so we can use the docker image from this branch to deploy u19 on devnet.Unsure if we actually wanna merge this in the release branch as it is just for instagoric validator nodes.