Skip to content

fix: don't continue if destChain not supported #11320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dckc
Copy link
Member

@dckc dckc commented Apr 23, 2025

closes: #XXXX
refs: #XXXX

Description

a return seems to be missing

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

TODO:

  • unit test

Upgrade Considerations

should roll out with the next Fast USDC upgrade following landing this

@dckc dckc requested a review from 0xpatrickdev April 23, 2025 21:03
Copy link

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0faa313
Status: ✅  Deploy successful!
Preview URL: https://aeff7ab5.agoric-sdk.pages.dev
Branch Preview URL: https://dc-dest-not-supported.agoric-sdk.pages.dev

View logs

Copy link
Contributor

@0xpatrickdev 0xpatrickdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving assuming a forthcoming test with coverage on 223-227. There are several existing ADVANCE_SKIPPED scenarios in settler.test.ts we should be able to follow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants