Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(dependency-graph): remove packing artifacts from cache #9413

Merged
merged 2 commits into from
May 28, 2024
Merged

ci(dependency-graph): remove packing artifacts from cache #9413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
250c6ec
ci(dependency-graph): remove packing artifacts from cache
michaelfig May 26, 2024
9878b43
test(a3p): temporarily make `fromTag` `use-upgrade-14`
michaelfig May 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions .github/workflows/test-all-packages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,13 +60,21 @@ jobs:
# Due to ambient types, certain build orders (from the dependency graph)
# may break the type resolution. Run this in the PR to find out before
# attempting to merge to master. This takes about 1min locally and since
# this job is about 30s in CI doing it here doesn't add to wall wait
# for CI resolution.
# We prepack only because full pack removes the declarations, relying on ambient
# resolution in the repo filesystem which will not be available when the packages
# are pulled from npm.
- name: Pack packages
run: yarn lerna run --reject-cycles --concurrency 1 prepack
# this job is about 30s in CI doing it here doesn't add to wall wait for
# CI resolution.
#
# We prepack only because full pack removes the declarations, relying on
# ambient resolution in the repo filesystem which will not be available
# when the packages are pulled from npm.
#
# After that test, we postpack to avoid putting the prepack artifacts in
# the cache maintained by restore-node, since they are not .gitignored and
# thus will fail restore-node's check for a clean repo when the cache is
# restored.
- name: Pack packages without ambient type resolution
run: |
yarn lerna run --reject-cycles --concurrency 1 prepack
yarn lerna run postpack

##################
# Lint tests
Expand Down
36 changes: 18 additions & 18 deletions a3p-integration/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,20 @@
{
"private": true,
"agoricSyntheticChain": {
"fromTag": "latest"
},
"scripts": {
"build": "yarn run build:sdk && yarn run build:submissions && yarn run build:synthetic-chain",
"build:sdk": "make -C ../packages/deployment docker-build-sdk",
"build:submissions": "scripts/build-all-submissions.sh",
"build:synthetic-chain": "yarn synthetic-chain build",
"test": "yarn synthetic-chain test",
"doctor": "yarn synthetic-chain doctor"
},
"dependencies": {
"@agoric/synthetic-chain": "^0.1.0",
"@types/better-sqlite3": "^7.6.9"
},
"packageManager": "yarn@4.1.1",
"license": "Apache-2.0"
"private": true,
"agoricSyntheticChain": {
"fromTag": "use-upgrade-14"
},
"scripts": {
"build": "yarn run build:sdk && yarn run build:submissions && yarn run build:synthetic-chain",
"build:sdk": "make -C ../packages/deployment docker-build-sdk",
"build:submissions": "scripts/build-all-submissions.sh",
"build:synthetic-chain": "yarn synthetic-chain build",
"test": "yarn synthetic-chain test",
"doctor": "yarn synthetic-chain doctor"
},
"dependencies": {
"@agoric/synthetic-chain": "^0.1.0",
"@types/better-sqlite3": "^7.6.9"
},
"packageManager": "yarn@4.1.1",
"license": "Apache-2.0"
}
Loading