Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contract): linting and typedefs #26

Closed
wants to merge 13 commits into from
Closed

feat(contract): linting and typedefs #26

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
4a7fdbd
fix: yarn lint is not working from contract directory
0xpatrickdev Dec 29, 2023
a6496a0
fix: eslint is complaining @endo/promise-kit is not available
0xpatrickdev Dec 29, 2023
7e3d0ed
chore(contract): yarn lint-fix
0xpatrickdev Dec 29, 2023
f2d6dfc
feat(contract): typedef improvements
0xpatrickdev Dec 30, 2023
a78ea8f
fix: zcf terms generic should only include custom terms
0xpatrickdev Jan 2, 2024
fdae180
chore: preserve import { E } from '@endor/far' convention
0xpatrickdev Jan 3, 2024
799e40f
chore: add _agstate/yarn-links to .gitignore
0xpatrickdev Jan 3, 2024
647f561
chore: move babel resolutions to ui directory
0xpatrickdev Jan 3, 2024
454c8c7
chore(contract): update dependencies to agoric-upgrade-13 versions
0xpatrickdev Jan 3, 2024
3ce6458
chore(contract): update lint script names
0xpatrickdev Jan 3, 2024
ad81605
feat: add local build script
0xpatrickdev Jan 3, 2024
f0a60ba
fix: joinPrice should be any AssetKind
0xpatrickdev Jan 3, 2024
ca54045
fix(contract): agoric bin path
0xpatrickdev Jan 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 11 additions & 12 deletions contract/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,18 +19,25 @@
"lint-jessie": "eslint -c '.eslintrc-jessie.js' '**/*.js'",
"typecheck": "tsc"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not critical:

elsewhere this is called lint:types and we have lint:eslint and lint does both.

see the PR linked from Agoric/agoric-sdk#8274 (reply in thread)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, didn't want to change lint-* as a part of this, but agree it should standardized.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see 3ce6458

},
"dependencies": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moving the "dependencies" section makes this diff hard to read.

"@agoric/ertp": "0.16.3-u13.0",
"@agoric/zoe": "0.26.3-u13.0",
Comment on lines +22 to +23
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you checked that the resulting bundle is a reasonable size? that we have just 1 version of each endo package?

"@endo/far": "0.2.18",
"@endo/marshal": "0.8.5",
"@endo/patterns": "0.2.2"
},
"devDependencies": {
"@agoric/deploy-script-support": "^0.10.4-u12.0",
"@agoric/deploy-script-support": "^0.10.4-u13.0",
"@agoric/eslint-config": "dev",
"@endo/bundle-source": "^2.8.0",
"@endo/bundle-source": "2.5.2-upstream-rollup",
"@endo/eslint-plugin": "^0.5.2",
"@endo/init": "^0.5.60",
"@endo/promise-kit": "^1.0.1",
"@endo/promise-kit": "0.2.56",
"@endo/ses-ava": "^0.2.44",
"@jessie.js/eslint-plugin": "^0.4.0",
"@typescript-eslint/eslint-plugin": "^6.7.0",
"@typescript-eslint/parser": "^6.7.0",
"agoric": "^0.21.2-u12.0",
"agoric": "^0.22.0-u13.0",
"ava": "^5.3.0",
"eslint": "^8.47.0",
"eslint-config-airbnb-base": "^15.0.0",
Expand All @@ -44,16 +51,8 @@
"import-meta-resolve": "^2.2.1",
"prettier": "^3.0.3",
"prettier-plugin-jsdoc": "^1.0.0",
"type-coverage": "^2.26.3",
"typescript": "~5.2.2"
},
"dependencies": {
"@agoric/ertp": "^0.16.3-u12.0",
"@agoric/zoe": "^0.26.3-u12.0",
"@endo/far": "^0.2.22",
"@endo/marshal": "^0.8.9",
"@endo/patterns": "^0.2.5"
},
"ava": {
"files": [
"test/**/test-*.js"
Expand Down
Loading