Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump import-meta-resolve #1270

Merged
merged 3 commits into from
Feb 13, 2025
Merged

bump import-meta-resolve #1270

merged 3 commits into from
Feb 13, 2025

Conversation

turadg
Copy link
Member

@turadg turadg commented Feb 13, 2025

Trying to fix failing integration test in agoric-sdk:

Link step
  ➤ YN0071: │ Cannot link @agoric/cosmic-swingset into @agoric/documentation@workspace:. dependency import-meta-resolve@npm:4.1.0 conflicts with parent dependency import-meta-resolve@npm:2.2.2
  ➤ YN0071: │ Cannot link @agoric/solo into @agoric/documentation@workspace:. dependency import-meta-resolve@npm:4.1.0 conflicts with parent dependency import-meta-resolve@npm:2.2.2
  ➤ YN0071: │ Cannot link @agoric/vats into @agoric/documentation@workspace:. dependency import-meta-resolve@npm:4.1.0 conflicts with parent dependency import-meta-resolve@npm:2.2.2

@turadg turadg requested a review from kriskowal February 13, 2025 18:35
Copy link

Deploying documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: 651dcff
Status: ✅  Deploy successful!
Preview URL: https://1be99780.documentation-7tp.pages.dev
Branch Preview URL: https://ta-meta-resolve.documentation-7tp.pages.dev

View logs

Copy link

Cloudflare deployment logs are available here

@turadg turadg enabled auto-merge (rebase) February 13, 2025 18:50
@turadg turadg requested a review from Chris-Hibbert February 13, 2025 18:50
@@ -5455,13 +5455,20 @@ __metadata:
languageName: node
linkType: hard

"import-meta-resolve@npm:^2.2.1, import-meta-resolve@npm:^2.2.2":
"import-meta-resolve@npm:^2.2.1":
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it a problem that something is still getting 2.2.1?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. yarn why reports it's the deps from agoric-sdk u17, which I think are used for the snippet building. Since that passes CI it's working.

❯ yarn why import-meta-resolve
├─ @agoric/builders@npm:0.2.0-upgrade-17-dev-ec448b0.0
│  └─ import-meta-resolve@npm:2.2.2 (via npm:^2.2.1)
│
├─ @agoric/cosmic-swingset@npm:0.42.0-u17.1
│  └─ import-meta-resolve@npm:2.2.2 (via npm:^2.2.1)
│
├─ @agoric/cosmic-swingset@npm:0.42.0-upgrade-17-dev-ec448b0.0
│  └─ import-meta-resolve@npm:2.2.2 (via npm:^2.2.1)
│
├─ @agoric/documentation@workspace:.
│  └─ import-meta-resolve@npm:4.1.0 (via npm:^4.1.0)
│
├─ @agoric/governance@npm:0.10.4-upgrade-17-dev-ec448b0.0
│  └─ import-meta-resolve@npm:2.2.2 (via npm:^2.2.1)
│
├─ @agoric/solo@npm:0.11.0-u17.1
│  └─ import-meta-resolve@npm:2.2.2 (via npm:^2.2.1)
│
├─ @agoric/swingset-vat@npm:0.33.0-upgrade-17-dev-ec448b0.0
│  └─ import-meta-resolve@npm:2.2.2 (via npm:^2.2.1)
│
├─ @agoric/swingset-vat@npm:0.33.0-upgrade-17-dev-ec448b0.0 [646b4]
│  └─ import-meta-resolve@npm:2.2.2 (via npm:^2.2.1)
│
├─ @agoric/vats@npm:0.16.0-u17.1
│  └─ import-meta-resolve@npm:2.2.2 (via npm:^2.2.1)
│
├─ @agoric/vats@npm:0.16.0-upgrade-17-dev-ec448b0.0
│  └─ import-meta-resolve@npm:2.2.2 (via npm:^2.2.1)
│
└─ @agoric/wallet@npm:0.19.0-upgrade-17-dev-ec448b0.0
   └─ import-meta-resolve@npm:2.2.2 (via npm:^2.2.1)

@turadg turadg merged commit 63ca7a2 into main Feb 13, 2025
6 checks passed
@turadg turadg deleted the ta/meta-resolve branch February 13, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants