You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are a few issues with @agoric/react-components:
Large bundle size (https://fastusdc.agoric.app/ has a 5.8MB JS bundle after compression) mostly due to chain registry and leap elements widget.
Difficult to customize wallet modal and IST onboarding popup (see screenshot). Seems like there's an issue with bundling interchain-ui/react within our own package and their styling engine doesn't seem to work well with that. Also we're removing IST altogether so that needs updating regardless (is it going to be BLD now?)
I think these issues can mostly be addressed by requiring the app to provide the dependencies rather than bundling them within the package, and maybe using an API for chain registry instead of bundling, I'll have to explore ideas though.
I think the main things are not importing the entire chain registry (it's a super large module that makes the bundle size giant), not including the leap elements widget by default (maybe we only export the client instead, it seems like the leap modal itself might have another copy of chain registry because it's so big). It's mainly used to onboard IST for smart wallet provisioning, which needs to be reworked anyway. And also, not bundling any of the Interchain UI stuff into the library, it just doesn't seem to be working. We should probably require the app/user to add all their own dependencies, and provide function arguments for rendering specific components that this library needs (just an idea, not necessarily).
Describe the bug
There are a few issues with
@agoric/react-components
:I think these issues can mostly be addressed by requiring the app to provide the dependencies rather than bundling them within the package, and maybe using an API for chain registry instead of bundling, I'll have to explore ideas though.
Possible Acceptance Criteria
If we're able to update the library and READMEs and create a new build of https://github.com/Agoric/fast-usdc-lp-ui with:
The text was updated successfully, but these errors were encountered: