Skip to content

Commit 89be3d7

Browse files
committed
Fix satisfiesVersion
1 parent 909d155 commit 89be3d7

File tree

2 files changed

+14
-2
lines changed

2 files changed

+14
-2
lines changed

library/helpers/satisfiesVersion.test.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,8 @@ t.test("it matches single range", async () => {
3636
t.equal(satisfiesVersion("^1.0.0", "0.0.0"), false);
3737
t.equal(satisfiesVersion("^1.0.0", "2.0.0"), false);
3838
t.equal(satisfiesVersion("^2.0.0", "1.0.0"), false);
39+
t.equal(satisfiesVersion("^1.2.1", "1.3.0"), true);
40+
t.equal(satisfiesVersion("^1.2.1", "1.2.0"), false);
3941
});
4042

4143
t.test("it matches multiple ranges", async () => {

library/helpers/satisfiesVersion.ts

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,19 @@ export function satisfiesVersion(range: string, version: string) {
4949
.split(".")
5050
.map((p) => parseInt(p, 10));
5151

52-
if (major === rMajor && minor >= rMinor && patch >= rPatch) {
53-
return true;
52+
if (major !== rMajor) {
53+
continue;
54+
}
55+
56+
if (minor < rMinor) {
57+
continue;
5458
}
59+
60+
if (minor === rMinor && patch < rPatch) {
61+
continue;
62+
}
63+
64+
return true;
5565
}
5666

5767
return false;

0 commit comments

Comments
 (0)