Merge pull request #451 from AikidoSec/ulid

Replace ULID identifiers in URL with `:ulid`

Author: willem-delbare

library/helpers/buildRouteFromURL.test.ts

@@ -157,3 +157,14 @@ t.test("it replaces BSON ObjectIDs", async () => {
     "/posts/:objectId"
   );
 });
+
+t.test("it replaces ULID strings", async () => {
+  t.same(
+    buildRouteFromURL("/posts/01ARZ3NDEKTSV4RRFFQ69G5FAV"),
+    "/posts/:ulid"
+  );
+  t.same(
+    buildRouteFromURL("/posts/01arz3ndektsv4rrffq69g5fav"),
+    "/posts/:ulid"
+  );
+});

library/helpers/buildRouteFromURL.ts

@@ -5,6 +5,7 @@ import { isIP } from "net";
 const UUID =
   /(?:[0-9a-f]{8}-[0-9a-f]{4}-[1-8][0-9a-f]{3}-[89ab][0-9a-f]{3}-[0-9a-f]{12}|00000000-0000-0000-0000-000000000000|ffffffff-ffff-ffff-ffff-ffffffffffff)$/i;
 const OBJECT_ID = /^[0-9a-f]{24}$/i;
+const ULID = /^[0-9A-HJKMNP-TV-Z]{26}$/i;
 const NUMBER = /^\d+$/;
 const DATE = /^\d{4}-\d{2}-\d{2}|\d{2}-\d{2}-\d{4}$/;
 const EMAIL =
@@ -44,6 +45,10 @@ function replaceURLSegmentWithParam(segment: string) {
     return ":uuid";
   }
 
+  if (segment.length === 26 && ULID.test(segment)) {
+    return ":ulid";
+  }
+
   if (segment.length === 24 && OBJECT_ID.test(segment)) {
     return ":objectId";
   }