Added skipping NPM build if .skip_npm_build flag file exists.

Author: AlexSkrypnyk

.devtools/assemble.sh

@@ -130,7 +130,21 @@ for composer_suggest in $composer_suggests; do
 done
 pass "Suggested dependencies installed."
 
+# If front-end dependencies are used in the project, package-lock.json is
+# expected to be committed to the repository.
+if [ -f "package-lock.json" ]; then
+  info "Installing front-end dependencies."
+  if [ -f ".nvmrc" ]; then nvm use; fi
+  if [ ! -d "node_modules" ]; then npm ci; fi
+
+  echo "> Building front-end dependencies."
+  if [ ! -f ".skip_npm_build" ]; then npm run build; fi
+  pass "Front-end dependencies installed."
+fi
+
 info "Copying tools configuration files."
+# Not every tool correctly resolves the path to the configuration file if it is
+# symlinked, so we copy them instead.
 cp phpcs.xml phpstan.neon phpmd.xml rector.php .twig-cs-fixer.php phpunit.xml "build/"
 pass "Tools configuration files copied."
 
@@ -139,21 +153,6 @@ rm -rf "build/web/${type}/custom" >/dev/null && mkdir -p "build/web/${type}/cust
 ln -s "$(pwd)"/* "build/web/${type}/custom/${extension}" && rm "build/web/${type}/custom/${extension}/build"
 pass "Extension's code symlinked."
 
-# If front-end dependencies are used in the project, package-lock.json is
-# expected to be committed to the repository.
-if [ -f "build/web/${type}/custom/${extension}/package-lock.json" ]; then
-  pushd "build/web/${type}/custom/${extension}" >/dev/null || exit 1
-
-  info "Installing front-end dependencies."
-  if [ -f ".nvmrc" ]; then nvm use; fi
-  if [ ! -d "node_modules" ]; then npm ci; fi
-  echo "> Build front-end dependencies."
-  npm run build
-  pass "Front-end dependencies installed."
-
-  popd >/dev/null || exit 1
-fi
-
 echo
 echo "==============================="
 echo "    🏗 ASSEMBLE COMPLETE ✅   "

.gitignore

@@ -1,3 +1,4 @@
 .logs
 composer.lock
 build
+node_modules

.scaffold/tests/bats/ahoy.bats

@@ -18,6 +18,22 @@ export BATS_FIXTURE_EXPORT_CODEBASE_ENABLED=1
   assert_dir_exists "${BUILD_DIR}/build/vendor"
   assert_file_exists "${BUILD_DIR}/build/composer.json"
   assert_file_exists "${BUILD_DIR}/build/composer.lock"
+  assert_dir_exists "${BUILD_DIR}/node_modules"
+  assert_output_contains "Would run build"
+}
+
+@test "ahoy assemble - skip NPM build" {
+  touch ".skip_npm_build"
+
+  run ahoy assemble
+  assert_success
+
+  assert_output_contains "ASSEMBLE COMPLETE"
+  assert_dir_exists "${BUILD_DIR}/build/vendor"
+  assert_file_exists "${BUILD_DIR}/build/composer.json"
+  assert_file_exists "${BUILD_DIR}/build/composer.lock"
+  assert_dir_exists "${BUILD_DIR}/node_modules"
+  assert_output_not_contains "Would run build"
 }
 
 @test "ahoy start" {

.scaffold/tests/bats/make.bats

@@ -24,6 +24,22 @@ export BATS_FIXTURE_EXPORT_CODEBASE_ENABLED=1
   assert_dir_exists "${BUILD_DIR}/build/vendor"
   assert_file_exists "${BUILD_DIR}/build/composer.json"
   assert_file_exists "${BUILD_DIR}/build/composer.lock"
+  assert_dir_exists "${BUILD_DIR}/node_modules"
+  assert_output_contains "Would run build"
+}
+
+@test "make assemble - skip NPM build" {
+  touch ".skip_npm_build"
+
+  run make assemble
+  assert_success
+
+  assert_output_contains "ASSEMBLE COMPLETE"
+  assert_dir_exists "${BUILD_DIR}/build/vendor"
+  assert_file_exists "${BUILD_DIR}/build/composer.json"
+  assert_file_exists "${BUILD_DIR}/build/composer.lock"
+  assert_dir_exists "${BUILD_DIR}/node_modules"
+  assert_output_not_contains "Would run build"
 }
 
 @test "make start" {

package-lock.json

@@ -12,7 +12,9 @@
   },
   "engines": {
     "npm": ">=8.0.0",
-    "node": ">=16.0.0"
+    "node": ">=18.0.0"
   },
-  "dependencies": {}
+  "dependencies": {
+    "is-positive": "^3.1.0"
+  }
 }

package.json

@@ -22,11 +22,8 @@
     <exclude-pattern>circle\.yml</exclude-pattern>
     <exclude-pattern>\.circle\/config\.yml</exclude-pattern>
 
-    <!-- Exclude theme assets. -->
-    <exclude-pattern>web\/themes\/custom\/.*\/build\/.*</exclude-pattern>
-    <exclude-pattern>web\/themes\/custom\/.*\/fonts\/.*</exclude-pattern>
-    <exclude-pattern>web\/themes\/custom\/.*\/images\/.*</exclude-pattern>
-    <exclude-pattern>web\/themes\/custom\/.*\/node_modules\/.*</exclude-pattern>
+    <!-- Exclude front-end assets. -->
+    <exclude-pattern>.*\/node_modules\/.*</exclude-pattern>
     <exclude-pattern>*\.min\.*</exclude-pattern>
 
     <!-- Force no empty lines after function opening brace. -->