Skip to content

Commit 9ce8201

Browse files
committed
a
1 parent 7b82264 commit 9ce8201

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

.devtools/assemble.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -171,6 +171,7 @@ pass "Suggested dependencies installed."
171171
# deprecation notices.
172172
# @see https://www.drupal.org/project/drupal/issues/1267246
173173
if [ "${SYMFONY_DEPRECATIONS_HELPER-}" == "disabled" ]; then
174+
note "Disabling deprecation notices in the functional tests."
174175
echo "error_reporting(E_ALL & ~E_DEPRECATED);" >>build/web/sites/default/default.settings.php
175176
fi
176177

.github/workflows/test.yml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,12 @@ jobs:
108108
php-version: ${{ matrix.php-version }}
109109
extensions: gd, sqlite, pdo_sqlite
110110

111+
# Disable Symfony deprecations helper for PHP 8.4+ until minor
112+
# versions of Drupal 10 and 11 core fully support PHP 8.4+.
113+
# @see https://www.drupal.org/project/drupal/issues/1267246
114+
- name: Update SYMFONY_DEPRECATIONS_HELPER for PHP 8.4+
115+
run: echo "SYMFONY_DEPRECATIONS_HELPER=$([[ "${{ matrix.php-version }}" < "8.4" ]] && echo 'disabled' || echo '')" >> $GITHUB_ENV
116+
111117
- name: Assemble the codebase
112118
run: .devtools/assemble.sh
113119
env:
@@ -145,11 +151,6 @@ jobs:
145151
run: vendor/bin/phpunit || [ "${CI_TEST_IGNORE_FAILURE:-0}" -eq 1 ]
146152
env:
147153
BROWSERTEST_OUTPUT_DIRECTORY: /tmp
148-
# Disable Symfony deprecations helper for PHP 8.4+ until minor
149-
# versions of Drupal 10 and 11 core fully support PHP 8.4+.
150-
# @see https://www.drupal.org/project/drupal/issues/1267246
151-
# SYMFONY_DEPRECATIONS_HELPER: ${{ matrix.php-version < '8.4' && 'disabled' }}
152-
SYMFONY_DEPRECATIONS_HELPER: 'disabled'
153154

154155
- name: Upload test results as an artifact
155156
uses: actions/upload-artifact@v4

0 commit comments

Comments
 (0)