Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: add config line number in warning and error messages #3217

Closed
mttbx opened this issue May 6, 2024 · 2 comments
Closed

feature request: add config line number in warning and error messages #3217

mttbx opened this issue May 6, 2024 · 2 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@mttbx
Copy link

mttbx commented May 6, 2024

add config line number if possible when there's an error in waybar config.

@github-actions github-actions bot added bug Something isn't working enhancement New feature or request labels May 6, 2024
@zjeffer
Copy link
Contributor

zjeffer commented May 6, 2024

JSON parsing errors already show the line number if you do something like this:

{
    "this-key-has-novalue": ,
    "this-key-does": true
}

which shows:

./build/waybar --config config.jsonc
[2024-05-06 19:52:13.594] [info] Using configuration file config.jsonc
[2024-05-06 19:52:13.595] [error] Error parsing JSON: * Line 2, Column 27
  Syntax error: value, object or array expected.

What other kind of config errors do you mean?

@mttbx
Copy link
Author

mttbx commented May 14, 2024

I don't remember what error it is. But some errors are not shown with line number.

@mttbx mttbx closed this as completed May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants