Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hyprland/language: incorrect language parsing #3487

Open
mexanoz opened this issue Jul 30, 2024 · 5 comments
Open

hyprland/language: incorrect language parsing #3487

mexanoz opened this issue Jul 30, 2024 · 5 comments
Labels

Comments

@mexanoz
Copy link

mexanoz commented Jul 30, 2024

The issue seems related/similar to #3222. Waybar seems to not parse the layout name correctly when it has commas in it, which causes it to display an empty string instead of the language indication. In this case, the offending layout name is "English (intl., with AltGr dead keys)".
Correct behavior:

[2024-07-30 19:46:48.254] [debug] hyprland IPC received activelayout>>at-translated-set-2-keyboard,Russian
[2024-07-30 19:46:48.322] [debug] hyprland language onevent with Russian
[2024-07-30 19:46:48.322] [debug] hyprland language update with full name Russian
[2024-07-30 19:46:48.322] [debug] hyprland language update with short name ru
[2024-07-30 19:46:48.322] [debug] hyprland language update with short description ru
[2024-07-30 19:46:48.322] [debug] hyprland language update with variant
[2024-07-30 19:46:48.322] [debug] hyprland language formatted layout name ru

Incorrect behavior:

[2024-07-30 19:47:23.460] [debug] hyprland IPC received activelayout>>at-translated-set-2-keyboard,English (intl., with AltGr dead keys)
[2024-07-30 19:47:23.514] [debug] hyprland language didn't find matching layout
[2024-07-30 19:47:23.514] [debug] hyprland language onevent with  with AltGr dead keys)
[2024-07-30 19:47:23.515] [debug] hyprland language update with full name
[2024-07-30 19:47:23.515] [debug] hyprland language update with short name
[2024-07-30 19:47:23.515] [debug] hyprland language update with short description
[2024-07-30 19:47:23.515] [debug] hyprland language update with variant
[2024-07-30 19:47:23.515] [debug] hyprland language formatted layout name

Note also that this only happens when switching the keymap and it works correctly when launching Waybar with this layout selected:

[2024-07-30 19:50:01.138] [debug] hyprland language update with full name English (intl., with AltGr dead keys)
[2024-07-30 19:50:01.138] [debug] hyprland language update with short name us
[2024-07-30 19:50:01.138] [debug] hyprland language update with short description en
[2024-07-30 19:50:01.138] [debug] hyprland language update with variant altgr-intl
[2024-07-30 19:50:01.138] [debug] hyprland language formatted layout name us

As additional info, I swear I remember this working correctly before and breaking like maybe a month ago. I didn't get to bisecting this yet but I might do so in some time.

@rom4kov
Copy link

rom4kov commented Aug 4, 2024

I have the exact same problem. It's also when I switch to the "English (intl., with AltGr dead keys)" that the waybar language module shows nothing and when I reload the waybar configuration or restart waybar it's showing the language layout code again.
I noticed this only today after I did a system update yesterday.

@FlyinPancake
Copy link

I have this issue too with Hungarian (QWERTY, 102-key, dot, dead keys) smh

@szaffarano
Copy link

Hi, same issue here

[2024-09-02 09:44:46.796] [debug] hyprland IPC received activelayout>>keychron-k2,English (intl., with AltGr dead keys)
[2024-09-02 09:44:46.803] [debug] hyprland language didn't find matching layout
[2024-09-02 09:44:46.803] [debug] hyprland language onevent with  with AltGr dead keys)
[2024-09-02 09:44:46.803] [debug] hyprland language update with full name 
[2024-09-02 09:44:46.803] [debug] hyprland language update with short name 
[2024-09-02 09:44:46.803] [debug] hyprland language update with short description 
[2024-09-02 09:44:46.803] [debug] hyprland language update with variant 
[2024-09-02 09:44:46.803] [debug] hyprland language formatted layout name US

It only happens when I switch keyboard layouts

@rom4kov
Copy link

rom4kov commented Oct 20, 2024

I created a pull request to solve this issue: #3700

@rom4kov
Copy link

rom4kov commented Oct 20, 2024

Just saw #3406 which offers a more complex solution of this issue that also addresses new problems that would have been introduced by my PR. My bad for not checking first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants