Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build Failure Nix Flake #3639

Closed
techyporcupine opened this issue Sep 24, 2024 · 2 comments · Fixed by #3640
Closed

Build Failure Nix Flake #3639

techyporcupine opened this issue Sep 24, 2024 · 2 comments · Fixed by #3640
Labels
clock custom sni

Comments

@techyporcupine
Copy link

Hello! I recently updated the Waybar input in my flake and it fails to build with

       > Running phase: unpackPhase
       > unpacking source archive /nix/store/ga7wi6s76i1gl0dwmwy82wcqyc3kqa4f-source
       > source root is source
       > /build/source /build
       > patching script interpreter paths in .
       > /build
       > Running phase: patchPhase
       > applying patch /nix/store/4dh7h9pnzxfa0l74116cz0x3ssnkpac7-fix-tray
       > patching file src/modules/sni/item.cpp
       > Reversed (or previously applied) patch detected!  Assume -R? [n]
       > Apply anyway? [n]
       > Skipping patch.
       > 5 out of 5 hunks ignored -- saving rejects to file src/modules/sni/item.cpp.rej
       > patching file subprojects/fmt.wrap
       > Reversed (or previously applied) patch detected!  Assume -R? [n]
       > Apply anyway? [n]
       > Skipping patch.
       > 1 out of 1 hunk ignored -- saving rejects to file subprojects/fmt.wrap.rej

Let me know if any more info is needed!
@mslxl
Copy link
Contributor

mslxl commented Sep 25, 2024

I met the same problem.

But it is so strange that I can run waybar by nix run github:Alexays/Waybar#waybar. And here is no patch operation in this repo(I didn't find it).

There is a patch operations related to waybar in nixpkgs: https://github.com/NixOS/nixpkgs/blob/5aaceeaf016fe2187f3fc6bda0520b8b468a1c3e/pkgs/by-name/wa/waybar/package.nix#L94-L104, but I did not use it. I run waybar by adding line exec-once = ${waybar.packages.${system}.waybar}/bin/waybar in hyprland config. Then I do not know how to solve it next.

Hope these info would help others.

@mslxl
Copy link
Contributor

mslxl commented Sep 25, 2024

Wait, it use overrideAttrs?

Waybar/nix/default.nix

Lines 15 to 19 in 07f75e3

};
in
(waybar.overrideAttrs (
oldAttrs: {
inherit version;

Maybe we should change it.

@mslxl mslxl mentioned this issue Sep 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
clock custom sni
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

nix: remove patches from downstream mslxl/Waybar
2 participants
@mslxl @techyporcupine