Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concept for an option to sort by number #1691

Closed
wants to merge 1 commit into from
Closed

Concept for an option to sort by number #1691

wants to merge 1 commit into from

Conversation

DriesOlbrechts
Copy link

As documented in #1596 , When workspace names are numbered, workspace 10 shows up before 2 - 9.
Adding a new config option seems like the preferred solution here.
I've created a working concept using stoi().
Very much open to feedback as I am not an experienced C++ developer.

@bgreggsmith
Copy link

What you're looking for is pretty much this #178

I'm also feeling the pain...

@DriesOlbrechts
Copy link
Author

What you're looking for is pretty much this #178

I'm also feeling the pain...

This doesn't feel like it solves the same thing?
Maybe I'm missing something

@primalmotion
Copy link

I tried this patch but it does not seem to do anything for me :/ Also do you mind squashing your commits? The https://github.com/Alexays/Waybar/pull/1691.patch is horrendous :)

@primalmotion
Copy link

My bad I had a typ in sort by coordinate, making it take precedence. Patch fixes the issue! :)

@DriesOlbrechts
Copy link
Author

I tried this patch but it does not seem to do anything for me :/ Also do you mind squashing your commits? The https://github.com/Alexays/Waybar/pull/1691.patch is horrendous :)

Will do I was thinking the same when I made it :p
Didn't think of squashing

@Alexays
Copy link
Owner

Alexays commented Oct 19, 2022

Closed in favor of #1721

@Alexays Alexays closed this Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants