[WirePlumber Module] Improvement, Added source node #1905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's just say I tried and that's it
|
Explanation why duplicated the methods: I tried to do deduplication of the methods with passing enum value as "Source" and "Sink" to update methods but that failed, it caused memory corruption and I think it's because wireplumber api, no idea what to do with that as I am not C++ dev so I just made function for each and it just works without memory corruption, super weird... to me at least |
|
Gentle ping :) This stuff is good, please consider to merge it |
|
@Arisa-Snowbell can you fix it? |
Alexays
force-pushed
the
master
branch
2 times, most recently
from
d623a89 to
a4d31ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made this for myself but when I am at it, I thought I could share it with the community as I enjoy using waybar.