Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wabar #3120

Closed
wants to merge 2 commits into from
Closed

wabar #3120

wants to merge 2 commits into from

Conversation

roastedcheese
Copy link

wabar :)

@xStormyy
Copy link

xStormyy commented Apr 7, 2024

We love Wabar

@Petingoso
Copy link

Wabar good
:)

@diniamo
Copy link

diniamo commented Apr 7, 2024

Please merge, this has been approved by Wikipedia itself.

https://en.wikipedia.org/wiki/Wabar

@offeex
Copy link

offeex commented Apr 7, 2024

wabar

AlephNought0
AlephNought0 approved these changes Apr 7, 2024
View reviewed changes
Copy link

@AlephNought0 AlephNought0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (wabar)

Rikonardo
Rikonardo approved these changes Apr 7, 2024
View reviewed changes
Copy link

@Rikonardo Rikonardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm wabar

offeex
offeex approved these changes Apr 7, 2024
View reviewed changes
Copy link

@offeex offeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wabar

ItsDrike
ItsDrike approved these changes Apr 7, 2024
View reviewed changes
Copy link
Contributor

@ItsDrike ItsDrike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit wabar

@bloxx12
Copy link

bloxx12 commented Apr 7, 2024

lgtm! 😃

bloxx12
bloxx12 approved these changes Apr 7, 2024 •
edited
Loading
View reviewed changes
bloxx12
bloxx12 approved these changes Apr 7, 2024 •
edited
Loading
View reviewed changes
diniamo
diniamo approved these changes Apr 7, 2024
View reviewed changes
Copy link

@diniamo diniamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rice-cracker-dev
Copy link

LGTM pls merge

@deviantsemicolon
Copy link

LGTM

Jappie3
Jappie3 suggested changes Apr 8, 2024
View reviewed changes
Copy link

@Jappie3 Jappie3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@roastedcheese you forgot the binary blob required for testing, please rework this MR

@roastedcheese
Copy link
Author

@roastedcheese you forgot the binary blob required for testing, please rework this MR

wabar

@ItsDrike
Copy link
Contributor

ItsDrike commented Apr 9, 2024

@roastedcheese you forgot the binary blob required for testing, please rework this MR

wabar

wabar

@xStormyy
Copy link

xStormyy commented Apr 9, 2024

@roastedcheese you forgot the binary blob required for testing, please rework this MR

wabar

wabar

wabar

@Alexays
Copy link
Owner

Alexays commented Apr 9, 2024

Thanks for this big PR, nice work!
I'll think about renaming myself Alexas instead of Alexays.

@NotAShelf
Copy link
Contributor

NotAShelf commented Apr 9, 2024 •
edited
Loading

We support you completely, congratulations @Alexas!

P.S: wabar
P.P.S: I'm sorry to the original @Alexas for the unsolicited mention`

@AlephNought0
Copy link

This is the true meaning of open-source.

JakeStanger
JakeStanger reviewed Apr 11, 2024
View reviewed changes
.github/workflows/clang-tidy.yml
@@ -10,7 +10,7 @@ jobs:
build:
runs-on: ubuntu-latest
container:
image: alexays/waybar:debian
image: alexays/wabar:debian
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In accordance with latest feedback from Alexas, it will now be necessary to change throughout:

Suggested change
image: alexays/wabar:debian
image: alexas/wabar:debian

JakeStanger
JakeStanger reviewed Apr 11, 2024
View reviewed changes
Copy link
Contributor

@JakeStanger JakeStanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alexas/wabar

@mariesavch
Copy link
Contributor

wabar

@imnotpoz
Copy link

hello. why was this closed? @roastedcheese I need this implemented

@offeex
Copy link

offeex commented Aug 21, 2024 •
edited
Loading

Please reopen

We need wabar before gta6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeStanger JakeStanger JakeStanger left review comments

@Jappie3 Jappie3 Jappie3 requested changes

@ItsDrike ItsDrike ItsDrike approved these changes

@Rikonardo Rikonardo Rikonardo approved these changes

@diniamo diniamo diniamo approved these changes

@NotAShelf NotAShelf NotAShelf approved these changes

@AlephNought0 AlephNought0 AlephNought0 approved these changes

@offeex offeex offeex approved these changes

@deviantsemicolon deviantsemicolon deviantsemicolon approved these changes

@bloxx12 bloxx12 bloxx12 approved these changes

@xStormyy xStormyy xStormyy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.