Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding sway/workspaces:persistant_workspaces #330

Merged
merged 8 commits into from
May 20, 2019

Conversation

Organic-Code
Copy link
Contributor

Implements #210

Adds the persistant_workspaces option to the module sway/workspaces.
Within persistant_workspaces, you can list workspaces that should always be showed, even when non existant as per sway. It is possible to indicate which outputs they should be displayed on ; if no output was indicated, it will display on all outputs.

example:

"sway/workspaces": {
    "persistant_workspaces": {
        "3": [], // Always show a workspace with name '3', on all outputs if it does not exists
        "4": ["eDP-1"], // Always show a workspace with name '4', on output 'eDP-1' if it does not exists
        "5": ["eDP-1", "DP-2"] // Always show a workspace with name '5', on outputs 'eDP-1' and 'DP-2' if it does not exists
    }
}

Known issue: upon clicking on a non-existing workspace, the new workspace will be created and opened on the output that is currently focused, instead of on the one where the click occured (except if there are further restriction on sway's config)

@Alexays
Copy link
Owner

Alexays commented May 20, 2019

Just pushed a commit in order to focus the correct workspace, and fix an ordering pb.
LGTM! Nice work!

Persistant workspaces would reorder upon their first creation
@Organic-Code
Copy link
Contributor Author

Fixed another ordering pb 😛
If it's good for you, I'll update the wiki then

Thanks!

@Alexays Alexays merged commit e387955 into Alexays:master May 20, 2019
@Alexays Alexays mentioned this pull request May 20, 2019
@sethidden
Copy link

sethidden commented Nov 26, 2021

Sorry for necro, but if anyone comes across this in the future, this is now persistent_workspaces, not persistant_workspaces. See 2646390

@ardishko
Copy link

I was about to point that out lmao

@mairm1340
Copy link

will this work on hyperland ?

@ardishko
Copy link

ardishko commented Jun 9, 2023

will this work on hyperland ?

Yes, all wlroots based compositors will work with Waybar's workspace module.

I am on Hyprland now, and can confirm this is the case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants