Fix std::bad_casts in tray module
#3604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a4d31ab.
khaneliman
approved these changes
Sep 15, 2024
pld-gitsync
pushed a commit
to pld-linux/waybar
that referenced
this pull request
Sep 15, 2024
algitbot
pushed a commit
to alpinelinux/aports
that referenced
this pull request
Sep 24, 2024
Patch pulled from Alexays/Waybar#3604
LukashonakV
pushed a commit
to LukashonakV/Waybar
that referenced
this pull request
Oct 23, 2024
Signed-off-by: Viktar Lukashonak <myxabeer@gmail.com>
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fmt 11.0.1 was broken: it wasn't using our
Glib::ustringformatter. This has been fixed long time ago in 11.0.2 and shouldn't be worked around in the code.Reverted the changes and updated fmt wrap to 11.0.2.
11.0.2 can trigger
-Wstringop-overflowwarnings with gcc -O3; these are known false positives and will be addressed in the next release of fmt.Fixes #3597