Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello o/
I really dislike having random-looking systray icons, and I saw that others were looking for a way to customize them—so I decided to take a stab at adding some (very rudimentary) support for this.
Related issue: #1957 (it's more about themes, but figured there's no harm in linking it, in case it's good enough solution)
This isn't the cleanest solution, but it does work—at least for non-Electron apps. (Electron seems to have its own issues: electron/electron#40936).
This implementation allows users to override tray icons through their config, following the suggestion in #1400.
A couple of limitations:
To avoid unnecessary config reloading, I also introduced a per-tray icon manager singleton, since there wasn't a good place where both the config and the item ID were accessible at the same time.
Maybe it'd be useful for someone :) Let me know if you have some suggestions