Provide an option to show ipv4, ipv6 or both

[voiceroy]

Fixes #3956.

Users can now set family to ipv4, ipv6, ipv4_6 to show the IPv4, IPv6, or both. With the default being ipv4.

[christoph-heiss]

Would it be possible to put each address family on each own line?

I've just tried the patch out, and

1. the first line gets really long with both in there, esp. since IPv6 address tend to be long.
2. on dual-stack, the netmask is displayed incorrectly, as it takes the one from legacy IPv4 for both. E.g. it displays 192.168.0.10 | fc00::1/24 via 192.168.0.1 if your interface has both 192.168.0.10/24 and fc00::1/64 as address.
3. on dual-stack, only the gateway for the legacy IPv4 net is displayed.

Putting each address family on its own line would fix both problems.

[voiceroy]

1. Something like this? Would a newline be good, or some other character?

else if (addr_pref_ == ip_addr_pref::IPV4_6) {
    final_ipaddr_ = ipaddr_;
    final_ipaddr_ += "\n";
    final_ipaddr_ += ipaddr6_;
  }

2. Adding new format replacements will fix it
3. There's a bug that affects gateway address retrieval 1564, 1279. Personally I haven't got any results with {gwaddr} in the format string.

[christoph-heiss]

1. Something like this? Would a newline be good, or some other character?

Yes, that's what I had in mind too. 👍

3. There's a bug that affects gateway address retrieval 1564, 1279. Personally I haven't got any results with {gwaddr} in the format string.

I see. I'd say that this is out of scope for this PR then. I might also look into this in the future, after this has been merged - to fix the immediate issues first.

[voiceroy]

Can you check the changes and verify that they work as intended?

[VAWVAW]

Could you add different {ipaddr4} and {ipaddr6} formats so that users have more flexibility?

My use case is that I want only the ipv4 address in the bar but both addresses in the tooltip.

[christoph-heiss]

One more, small change :^)

The format (apart from the broken netmask as already discussed) now seems fine. It's kinda sad that still only a minority of people care about IPv6, seeing the state of this module.

Anyway; one more thing I noticed: when a legacy v4 address is added, the module updates fine. But if the legacy address is removed again, it completely disappears from the bar.

[christoph-heiss]

Suggested change

	final_ipaddr_ = ipaddr_;
	final_ipaddr_ += '\n';
	if (!ipaddr_.empty()) {
	final_ipaddr_ = ipaddr_;
	final_ipaddr_ += '\n';
	}

Small nit; to avoid an unnecessary newline/empty line.

[voiceroy]

Could you add different {ipaddr4} and {ipaddr6} formats so that users have more flexibility?

My use case is that I want only the ipv4 address in the bar but both addresses in the tooltip.

I think you can just display ipv4 in the bar and ipv4_6 in the tooltip.

[VAWVAW]

I think you can just display ipv4 in the bar and ipv4_6 in the tooltip.

How would I do this? As far a I see, setting family affects the format of {ipaddr} in both format and tooltip-format.

[voiceroy]

I think you can just display ipv4 in the bar and ipv4_6 in the tooltip.

How would I do this? As far a I see, setting family affects the format of {ipaddr} in both format and tooltip-format.

Oh yeah, sorry. Didn't think about that. Maybe you can create a separate pr for that if you don't mind.